You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 16:38:48 UTC

[GitHub] [arrow] jonkeane opened a new pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

jonkeane opened a new pull request #12770:
URL: https://github.com/apache/arrow/pull/12770


   For a while now glue has been removing the tabs before: (this might be from https://github.com/tidyverse/glue/commit/8369f9afe09cc52847624d2e55f0f72ce64ef25a which was to change [a different thing we noticed with whitespace stripping](https://github.com/tidyverse/glue/issues/247)).
   
   Regardless, the fix is easy enough (don't include new lines around the line we are glueing)
   
   Before the change, the format of the relevant lines of arrowExports.cpp are:
   ```
   static const R_CallMethodDef CallEntries[] = {
   { "_arrow_available", (DL_FUNC)& _arrow_available, 0 },
   { "_dataset_available", (DL_FUNC)& _dataset_available, 0 },
   { "_engine_available", (DL_FUNC)& _engine_available, 0 },
   { "_parquet_available", (DL_FUNC)& _parquet_available, 0 },
   { "_s3_available", (DL_FUNC)& _s3_available, 0 },
   { "_json_available", (DL_FUNC)& _json_available, 0 },
   { "_arrow_test_SET_STRING_ELT", (DL_FUNC) &_arrow_test_SET_STRING_ELT, 1}, 
   ```
     
   When they should be:
   ```
   static const R_CallMethodDef CallEntries[] = {
   		{ "_arrow_available", (DL_FUNC)& _arrow_available, 0 },
   		{ "_dataset_available", (DL_FUNC)& _dataset_available, 0 },
   		{ "_engine_available", (DL_FUNC)& _engine_available, 0 },
   		{ "_parquet_available", (DL_FUNC)& _parquet_available, 0 },
   		{ "_s3_available", (DL_FUNC)& _s3_available, 0 },
   		{ "_json_available", (DL_FUNC)& _json_available, 0 },
   		{ "_arrow_test_SET_STRING_ELT", (DL_FUNC) &_arrow_test_SET_STRING_ELT, 1}, 
   ```
   
   This change restores the indentation we expect there (so the file won't change on rebuilds)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane closed pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #12770:
URL: https://github.com/apache/arrow/pull/12770


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1084984679


   I would be curious if this looks like a new bug in glue or if it's really just alignment with the documented behavior and we were relying on the not-to-spec behavior (I'm leaning towards the second option, but would love a second opinion!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/412| `a1f32fab` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Finished :arrow_down:0.17% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/412| `a1f32fab` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Finished :arrow_down:0.17% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/412| `a1f32fab` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/411| `a1a255bf` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Finished :arrow_down:0.17% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Failed :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/412| `a1f32fab` test-mac-arm>
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/412| `a1f32fab` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/411| `a1a255bf` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Finished :arrow_down:0.17% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/412| `a1f32fab` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/412| `a1f32fab` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/411| `a1a255bf` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12770:
URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469


   Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6953e96903d07a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/072e10a763af4cdb8a66410d8ddf4c03...ff1e0cf0e75f4a639f4f109fb66778ee/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3365d50bdf41485e85ba1e7d86591a59...8c5d687eedd7499aac49aaed9903b6d7/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/68b177499cf74a3f99991cd0922e400b...2399f6ea7aff49f8960d3ff7bdc0e7f7/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f3cfd67bc6ae4447ad9257b51753d9df...8c2b1de859e34db19cac4895133453a5/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/427| `a1f32fab` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/412| `a1f32fab` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/422| `a1f32fab` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/426| `a1a255bf` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/411| `a1a255bf` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/421| `a1a255bf` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org