You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by BigstickCarpet <gi...@git.apache.org> on 2014/12/11 21:41:27 UTC
[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
GitHub user BigstickCarpet opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/28
Internet Explorer browser support
Added support for Internet Explorer and other browsers when using the new "browser" platform in Cordova 4.
Chrome, Safari, and Firefox were already supported, but when using IE or any other browser an error would occur because the user agent string wasn't recognized.
I added specific logic to parse Internet Explorer's user agent string. Note that IE 11's user agent string doesn't include "MSIE", so I search for "Trident" instead.
I also fixed the bug that caused an error if the user agent wasn't recognized, so if a browser other than Chrome, Safari, Firefox, or IE is used, the plugin will still work. It just won't have the `device.model` or `device.version` set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BigstickCarpet/cordova-plugin-device master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit 3f1e1c96b775653b6a594be1b39d34b8df45772b
Author: James Messinger <ja...@ventyx.abb.com>
Date: 2014-12-11T20:26:37Z
- Fixed a bug that caused an "cannot call method of undefined" error if the browser's user agent wasn't recognized
- Added support for Internet Explorer user agent strings
- NOTE: IE 11's user agent string does not include "MSIE", so "Trident" is searched for instead
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
Posted by BigstickCarpet <gi...@git.apache.org>.
Github user BigstickCarpet commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-66696150
Ok. I'll fill out an iCLA and send it in later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
Posted by BigstickCarpet <gi...@git.apache.org>.
Github user BigstickCarpet commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-66826434
@purplecabbage I just got an email confirming that my iCLA is now on file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
Posted by BigstickCarpet <gi...@git.apache.org>.
Github user BigstickCarpet commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-68895043
What is the planned release date for this fix? `cordova plugin add org.apache.cordova.device` still gets the version without the fix, so it still doesn't work in IE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-plugin-device pull request: Internet Explorer
browser supp...
Posted by Jesse <pu...@gmail.com>.
Sorry James, just realized I called you Jim ...
Call me whatever you want.
@purplecabbage
risingj.com
On Thu, Dec 11, 2014 at 1:08 PM, purplecabbage <gi...@git.apache.org> wrote:
> Github user purplecabbage commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-66688982
>
> This looks good Jim. Have you sent an iCLA to apache? I did not see
> your name listed.
> http://cordova.apache.org/#contribute
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-66688982
This looks good Jim. Have you sent an iCLA to apache? I did not see your name listed.
http://cordova.apache.org/#contribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org