You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2026/05/07 01:00:05 UTC
[PR] KAFKA-20553 Eliminate the dependencies on "sourceSets.test.output" (Server-common) [kafka]
m1a2st opened a new pull request, #22229:
URL: https://github.com/apache/kafka/pull/22229
Gradle test fixtures to the clients module and removes all dependencies on sourceSets.test.output. We should revisit other usages in this JIRA.
This will simplify the dependency graph and unblock the upgrade to Gradle 9.5+
This patch is working on server-common module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20553 Eliminate the dependencies on "sourceSets.test.output" (Server-common) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #22229:
URL: https://github.com/apache/kafka/pull/22229#discussion_r3203746158
##########
build.gradle:
##########
@@ -4067,6 +4075,13 @@ gradle.projectsEvaluated {
ERROR: Dependency on :clients test output is not allowed.
Found in project ${proj.path} configuration '${config.name}'.
Use `testFixtures(project(':clients'))` instead of `project(':clients').sourceSets.test.output`
+""")
+ }
+ if (file.absolutePath.endsWith('/server-common/build/classes/java/test')) {
Review Comment:
Would you mind using array to eliminate duplicate code?
##########
build.gradle:
##########
@@ -4214,7 +4229,7 @@ def verifyVersionConsistencyTask = tasks.register('verifyVersionConsistency') {
// Check if regex matches current content "as is"
// Note: We need to see if the file content *already* matches what we want it to be.
// One way is to simulate the replacement and see if it changes nothing.
-
+
Review Comment:
please revert unrelated changes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20553 Eliminate the dependencies on "sourceSets.test.output" (Server-common) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #22229:
URL: https://github.com/apache/kafka/pull/22229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20553 Eliminate the dependencies on "sourceSets.test.output" (Server-common) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #22229:
URL: https://github.com/apache/kafka/pull/22229#discussion_r3210234634
##########
build.gradle:
##########
@@ -2260,6 +2262,12 @@ project(':server-common') {
implementation libs.pcollections
implementation libs.slf4jApi
+ testFixturesImplementation testFixtures(project(':clients'))
+ testFixturesApi libs.slf4jApi
Review Comment:
Could we try using testFixturesImplementation instead of testFixturesApi? It's generally a best practice to let downstream modules explicitly declare their own dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org