You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by barcahead <gi...@git.apache.org> on 2017/04/06 12:49:20 UTC
[GitHub] flink pull request #3688: [FLINK-6273] [core] don't convert hostname to lowe...
GitHub user barcahead opened a pull request:
https://github.com/apache/flink/pull/3688
[FLINK-6273] [core] don't convert hostname to lower cases to prevent akka connection failure
For akka `Address`, the host part is case sensitive, So if we build remote jobmanager url with lower case hostname, akka will reject message.
I fix this issue by removing `toLowerCase` when building actor url.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barcahead/flink FLINK-6273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3688.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3688
----
commit f5f4f5823bb5f3de9484987a849a0a73906732a6
Author: fengyelei <fe...@huawei.com>
Date: 2017-04-06T12:31:27Z
[FLINK-6273] [core] don't convert hostname to lower cases to prevent akka connection failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3688: [FLINK-6273] [core] don't convert hostname to lower cases...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3688
Thanks!
---
[GitHub] flink pull request #3688: [FLINK-6273] [core] don't convert hostname to lowe...
Posted by barcahead <gi...@git.apache.org>.
Github user barcahead closed the pull request at:
https://github.com/apache/flink/pull/3688
---
[GitHub] flink issue #3688: [FLINK-6273] [core] don't convert hostname to lower cases...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3688
@barcahead could you please close this because it has been superseded by #4812
---
[GitHub] flink issue #3688: [FLINK-6273] [core] don't convert hostname to lower cases...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3688
@barcahead would it be safer to also normalize the value of `jobmanager.rpc.address`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---