You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/13 17:10:21 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #12921: [BEAM-10009] Document micros_instant

lukecwik commented on a change in pull request #12921:
URL: https://github.com/apache/beam/pull/12921#discussion_r504122208



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -928,7 +928,13 @@ message StandardCoders {
     //     values.
     //   - For present values the null indicator is followed by the value
     //     encoded with it's corresponding coder.
-    //
+    // 
+    // Well known logical types:
+    //   beam:logical_type:micros_instant:v1
+    //   - Representation type: ROW<seconds: INT64, micros: INT64>
+    //   - A timezone naive timestamp where seconds + micros represents the

Review comment:
       ```suggestion
       //   - A timestamp without a timezone where seconds + micros represents the
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org