You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/16 00:01:26 UTC

[GitHub] [flink] StephanEwen opened a new pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

StephanEwen opened a new pull request #12187:
URL: https://github.com/apache/flink/pull/12187


   ## What is the purpose of the change
   
   This PR is a set of follow-up suggestion to PR #11722 (Make savepoints self-contained and relocatable)
   
   Please refer to the original PR for description and discussion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629564928


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4303ba5e61629f55a3f03acf1b6444878c7aadce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1480",
       "triggerID" : "4303ba5e61629f55a3f03acf1b6444878c7aadce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4303ba5e61629f55a3f03acf1b6444878c7aadce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1480) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

StephanEwen commented on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629628123


   Thanks for reviewing this. I will add a test for the entropy injection bug and then merge both PRs together.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629554680

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 732b737e400f84bdbc219f15f386810bdf954acb (Sat May 16 00:03:14 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

StephanEwen commented on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629663290


   Manually merged in 4ee41bebc504880c7224ec29ffdd4cf28f5fc218


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen closed pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

StephanEwen closed pull request #12187:
URL: https://github.com/apache/flink/pull/12187


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] klion26 commented on a change in pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

klion26 commented on a change in pull request #12187:
URL: https://github.com/apache/flink/pull/12187#discussion_r426109495



##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/EntropyInjector.java
##########
@@ -89,6 +89,10 @@ public static Path removeEntropyMarkerIfPresent(FileSystem fs, Path path) {
 
 	// ------------------------------------------------------------------------
 
+	public static boolean isEntropyInjecting(FileSystem fs) {
+		return getEntropyFs(fs) == null;

Review comment:
       `getEntropyFs(fs) != null;`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629564928


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4303ba5e61629f55a3f03acf1b6444878c7aadce",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4303ba5e61629f55a3f03acf1b6444878c7aadce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4303ba5e61629f55a3f03acf1b6444878c7aadce UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629564928


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4303ba5e61629f55a3f03acf1b6444878c7aadce",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1480",
       "triggerID" : "4303ba5e61629f55a3f03acf1b6444878c7aadce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4303ba5e61629f55a3f03acf1b6444878c7aadce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1480) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12187:
URL: https://github.com/apache/flink/pull/12187#issuecomment-629554680

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 4303ba5e61629f55a3f03acf1b6444878c7aadce (Fri Oct 16 10:33:12 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on a change in pull request #12187: [FLINK-5763][state backends] (follow-up) Make savepoints self-contained and relocatable

Posted by GitBox <gi...@apache.org>.

StephanEwen commented on a change in pull request #12187:
URL: https://github.com/apache/flink/pull/12187#discussion_r426143213



##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/EntropyInjector.java
##########
@@ -89,6 +89,10 @@ public static Path removeEntropyMarkerIfPresent(FileSystem fs, Path path) {
 
 	// ------------------------------------------------------------------------
 
+	public static boolean isEntropyInjecting(FileSystem fs) {
+		return getEntropyFs(fs) == null;

Review comment:
       You are right, definitely. This hints that I need to add a test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org