[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #591: LOG4J2-2829 SocketAppender should propagate failures when reconnection fails.

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#discussion_r735020059



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
##########
@@ -238,7 +238,10 @@ protected void write(final byte[] bytes, final int offset, final int length, fin
                                         config),
                                 causeEx);
                     }
+                    return;
                 }
+                final String message = String.format("Error writing to %s for connection %s", getName(), config);

Review comment:
       Not sure we need a temp var here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org