[jira] [Commented] (TS-3799) Padded DATA frames lead to PROTOCOL_ERROR

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643527#comment-14643527 ] 

ASF GitHub Bot commented on TS-3799:
------------------------------------

GitHub user maskit opened a pull request:

    https://github.com/apache/trafficserver/pull/263

    TS-3799: Fix handling of padding in DATA frames

    Traffic Server doesn't handle padded DATA frames correctly, and returns GOAWAY frame with PROTOCOL_ERROR.
    https://issues.apache.org/jira/browse/TS-3799

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maskit/trafficserver ts-3799

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit 88da58910e2818cdcb5021c96bc167a098bdf9a3
Author: Masakazu Kitajo <m4...@gmail.com>
Date:   2015-07-27T21:30:43Z

    TS-3799: Fix handling of padding in DATA frames

----


> Padded DATA frames lead to PROTOCOL_ERROR
> -----------------------------------------
>
>                 Key: TS-3799
>                 URL: https://issues.apache.org/jira/browse/TS-3799
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>    Affects Versions: 5.3.0, 6.0.0
>            Reporter: Masakazu Kitajo
>
> Padded DATA frames lead to PROTOCOL_ERROR because of wrong data size calculation.
> https://github.com/apache/trafficserver/blob/6.0.x/proxy/http2/Http2ConnectionState.cc#L88
> The size should be sum of real data sizes without padding but not payload sizes.
> How to reproduce:
> {noformat}
> $ nghttp -v --padding=123 -d foo http://localhost:8080/
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)