You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Surya Hebbar (Code Review)" <ge...@cloudera.org> on 2023/05/11 10:30:10 UTC

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19872


Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................

IMPALA-12133: Fix query timeline display height for compact query plans

The patch resizes the fragment diagram for small query plans
on the query timeline, eliminating unnecessary spacing below it.

Lowest value of display_height and fragment diagram's height
are taken by multiplying row_height and rownum.

Constant folding implementations in browsers guarantee
optimal rendering without performance degradation.

Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
---
M www/query_timeline.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/19872/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 12:13:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 1:

Verified the code change on local machine. It works as expected.
Please fix the comment from Kurt.


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 17:07:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 15:44:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 2:

(1 comment)

Thank you. The formatting has been fixed.

http://gerrit.cloudera.org:8080/#/c/19872/1/www/query_timeline.tmpl
File www/query_timeline.tmpl:

http://gerrit.cloudera.org:8080/#/c/19872/1/www/query_timeline.tmpl@343
PS1, Line 343:   var display_height = Math.min(window.innerHeight - timing_diagram.offsetTop - 70,
> Wrap long line
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 02:25:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12995/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 10:53:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 08:00:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................

IMPALA-12133: Fix query timeline display height for compact query plans

The patch resizes the fragment diagram for small query plans
on the query timeline, eliminating unnecessary spacing below it.

Lowest value of display_height and fragment diagram's height
are taken by multiplying row_height and rownum.

Constant folding implementations in browsers guarantee
optimal rendering without performance degradation.

Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
---
M www/query_timeline.tmpl
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/19872/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19872/1/www/query_timeline.tmpl
File www/query_timeline.tmpl:

http://gerrit.cloudera.org:8080/#/c/19872/1/www/query_timeline.tmpl@343
PS1, Line 343:   var display_height = Math.min(window.innerHeight - timing_diagram.offsetTop - 70, rownum * row_height);
Wrap long line



-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 May 2023 16:52:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9309/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 02:43:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................

IMPALA-12133: Fix query timeline display height for compact query plans

The patch resizes the fragment diagram for small query plans
on the query timeline, eliminating unnecessary spacing below it.

Lowest value of display_height and fragment diagram's height
are taken by multiplying row_height and rownum.

Constant folding implementations in browsers guarantee
optimal rendering without performance degradation.

Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Reviewed-on: http://gerrit.cloudera.org:8080/19872
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Kurt Deschler <kd...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Kurt Deschler: Looks good to me, but someone else must approve
  Wenzhe Zhou: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 4
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12133: Fix query timeline display height for compact query plans

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19872 )

Change subject: IMPALA-12133: Fix query timeline display height for compact query plans
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13012/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91
Gerrit-Change-Number: 19872
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 02:46:12 +0000
Gerrit-HasComments: No