You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "suicide11 (via GitHub)" <gi...@apache.org> on 2023/09/01 09:54:59 UTC
[GitHub] [superset] suicide11 opened a new pull request, #25157: fix: Resolved report selection menu in chart and dashboard page
suicide11 opened a new pull request, #25157:
URL: https://github.com/apache/superset/pull/25157
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
When we used to click on Manage Email report and then select Setup Email report, a new dialogue used to open but the submenu remains in the DOM. To remove that I have added rest props. I have checked other functionalities as well and they were working as expected.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before
#### After
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suicide11 commented on a diff in pull request #25157: fix: Issue #24493; Resolved report selection menu in chart and dashboard page
Posted by "suicide11 (via GitHub)" <gi...@apache.org>.
suicide11 commented on code in PR #25157:
URL: https://github.com/apache/superset/pull/25157#discussion_r1313711123
##########
superset-frontend/src/features/reports/ReportModal/HeaderReportDropdown/index.tsx:
##########
@@ -214,15 +215,17 @@ export default function HeaderReportDropDown({
const textMenu = () =>
isEmpty(report) ? (
- <Menu selectable={false} css={onMenuHover}>
+ <Menu selectable={false} {...rest} css={onMenuHover}>
<Menu.Item onClick={handleShowMenu}>
{DropdownItemExtension ? (
<StyledDropdownItemWithIcon>
<div>{t('Set up an email report')}</div>
<DropdownItemExtension />
</StyledDropdownItemWithIcon>
) : (
- t('Set up an email report')
+ <React.Fragment>
Review Comment:
Sure will remove that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #25157: fix: Issue #24493; Resolved report selection menu in chart and dashboard page
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #25157:
URL: https://github.com/apache/superset/pull/25157#issuecomment-1703444074
Thanks for the fix @suicide11!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #25157: fix: Issue #24493; Resolved report selection menu in chart and dashboard page
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #25157:
URL: https://github.com/apache/superset/pull/25157#discussion_r1313619983
##########
superset-frontend/src/features/reports/ReportModal/HeaderReportDropdown/index.tsx:
##########
@@ -214,15 +215,17 @@ export default function HeaderReportDropDown({
const textMenu = () =>
isEmpty(report) ? (
- <Menu selectable={false} css={onMenuHover}>
+ <Menu selectable={false} {...rest} css={onMenuHover}>
<Menu.Item onClick={handleShowMenu}>
{DropdownItemExtension ? (
<StyledDropdownItemWithIcon>
<div>{t('Set up an email report')}</div>
<DropdownItemExtension />
</StyledDropdownItemWithIcon>
) : (
- t('Set up an email report')
+ <React.Fragment>
Review Comment:
you probably don't need the React.Fragment here since there's a singular div as the child.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #25157: fix: Issue #24493; Resolved report selection menu in chart and dashboard page
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #25157:
URL: https://github.com/apache/superset/pull/25157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org