You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/17 16:58:03 UTC

[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #4776: Replace deprecated RuntimeIOException with UncheckedIOException

ajantha-bhat commented on code in PR #4776:
URL: https://github.com/apache/iceberg/pull/4776#discussion_r875057628


##########
api/src/main/java/org/apache/iceberg/Files.java:
##########
@@ -59,9 +59,9 @@ public PositionOutputStream create() {
       }
 
       if (!file.getParentFile().isDirectory() && !file.getParentFile().mkdirs()) {
-        throw new RuntimeIOException(
+        throw new UncheckedIOException(new IOException(String.format(

Review Comment:
   Yeah. Very few places have this. For these cases, shall I replace `UncheckedIOException` with a new exception class similar to the existing `NotFoundException` which extends `RuntimeException`?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org