You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/11 10:03:13 UTC

[GitHub] [incubator-yunikorn-k8shim] manirajv06 edited a comment on pull request #380: [YUNIKORN-1090] remove common.Node from the shim

manirajv06 edited a comment on pull request #380:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/380#issuecomment-1064957246


   Observed few more things while doing the clean up:
   
   1. I can see few more places where SchedulerNode properties gets updated without having proper lock mechanism in place. For example, `schedulerNode.occupied = common.Add(schedulerNode.occupied, resource)` in `updateNodeOccupiedResources` method. We should call `setOccupiedResource` here.
   2. I think we should start exploring and see if `sync.Map` makes sense instead of using `map` given the no. of reads and writes it is going through.
   
   Please share your views.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org