You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/29 08:57:04 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1107: system/libuv: Support specify stack size for worker thread

pkarashchenko commented on a change in pull request #1107:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1107#discussion_r837229499



##########
File path: system/libuv/0001-libuv-port-for-nuttx.patch
##########
@@ -169,7 +169,24 @@ index 869ae95f..8fabeba5 100644
  }
  
  
-@@ -212,7 +217,7 @@ static void init_threads(void) {
+@@ -188,6 +193,16 @@ static void init_threads(void) {
+   const char* val;
+   uv_sem_t sem;
+ 
++  const uv_thread_options_t params = {
++#ifdef DEF_THREADPOOL_STACKSIZE

Review comment:
       Seems like `DEF_THREADPOOL_STACKSIZE` is always defined, so why do we need to have `ifdef` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org