You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/09 16:26:23 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5451: drivers/mtd/sst39vf.c: patch adress map issue

xiaoxiang781216 commented on pull request #5451:
URL: https://github.com/apache/incubator-nuttx/pull/5451#issuecomment-1033947349


   > in sst39vf_bwrite function, the following code: wrinfo.address = (uintptr_t)SST39VF_ADDR((startblock * priv->chip->sectorsize)); already map sector address into cpu address space,the form is CONFIG_SST39VF_BASE_ADDRESS + offset_address but sst39vf_writeword call sst39vf_writeword and final in function sst39vf_flashwrite volatile uint16_t *addr = SST39VF_ADDR(wrinfo->address); duplicate map the address,and final form of address is 3 * CONFIG_SST39VF_BASE_ADDRESS + 2 * offset_address that's wrong!
   
   Should we fix the code to remove the duplicated map directly? instead of workaround by offset_address >> 1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org