You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rp...@apache.org on 2016/04/05 17:53:13 UTC
[21/23] logging-log4j2 git commit: LOG4J2-1344
MemoryMappedFileAppender.isImmediateFlush() should always return false to
prevent the remap() method from being called for each log event
LOG4J2-1344 MemoryMappedFileAppender.isImmediateFlush() should always return false to prevent the remap() method from being called for each log event
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/fd4ac53b
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/fd4ac53b
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/fd4ac53b
Branch: refs/heads/LOG4J2-1343-no-gc-outputstreamappenders
Commit: fd4ac53bab268957bd507d83f8ad0b7f94796ece
Parents: 209323c
Author: rpopma <rp...@apache.org>
Authored: Tue Apr 5 23:21:13 2016 +0900
Committer: rpopma <rp...@apache.org>
Committed: Tue Apr 5 23:21:13 2016 +0900
----------------------------------------------------------------------
.../logging/log4j/core/appender/MemoryMappedFileAppender.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/fd4ac53b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java
index a3cb25c..2d5d426 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java
@@ -36,7 +36,7 @@ import org.apache.logging.log4j.core.util.Integers;
/**
* Memory Mapped File Appender.
- *
+ *
* @since 2.1
*/
@Plugin(name = "MemoryMappedFile", category = "Core", elementType = "appender", printObject = true)
@@ -102,7 +102,7 @@ public final class MemoryMappedFileAppender extends AbstractOutputStreamAppender
/**
* Returns the length of the memory mapped region.
- *
+ *
* @return the length of the memory mapped region
*/
public int getRegionLength() {
@@ -170,7 +170,8 @@ public final class MemoryMappedFileAppender extends AbstractOutputStreamAppender
return null;
}
- return new MemoryMappedFileAppender(name, layout, filter, manager, fileName, ignoreExceptions, isForce,
+ // if superclass isImmediateFlush() is true, the ByteBufferDestination.drain() method will remap on every event
+ return new MemoryMappedFileAppender(name, layout, filter, manager, fileName, ignoreExceptions, false,
isAdvertise ? config.getAdvertiser() : null);
}