You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2023/05/01 23:03:40 UTC
[GitHub] [kafka] mjsax opened a new pull request, #13654: HOTFIX: fix broken Streams upgrade system test
mjsax opened a new pull request, #13654:
URL: https://github.com/apache/kafka/pull/13654
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits we've added this upon releasing the previous version. (Ie, cutting the branch for the new trunk as per the commit comments)
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270835742
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Could be -- I mean, it does not really hurt to add it early (it's just a definition of a var), but it's also useless to have, a nobody should use it, but use `DEV_VERSION` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1644683069
Hey did we mean to remove 3.6 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits, we've added this cutting the release branch for the previous version. (Ie, cutting the branch for the new trunk as per the commit comments) Seems like the top commit I linked should not have been reverted unless all of these were wrong.
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530817064
Timeout:
```
16:34:05 An error occurred while executing multiple actions in parallel.
16:34:05 Any errors that occurred are shown below.
16:34:05
16:34:05 An error occurred while executing the action on the 'worker27'
16:34:05 machine. Please handle this error then try again:
16:34:05
16:34:05 The instance never became "ready" in AWS. The timeout currently
16:34:05 set waiting for the instance to become ready is 120 seconds.
```
Re-triggered the run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270114193
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
I think the issue in David's commit was that he didn't set the dev version to match the new version defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1539079411
Merged to `trunk` and cherry-picked to `3.5` branch. \cc @mimaison
Seems some other streams system tests are still flaky (well, I hope it's not a real issue). I hope to find time to dig into it this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits, we've added this cutting the release branch for the previous version. (Ie, cutting the branch for the new trunk as per the commit comments)
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits we've added this cutting the release branch for the previous version. (Ie, cutting the branch for the new trunk as per the commit comments)
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530538551
\cc @mimaison as RM for 3.5.0 -- I hope we did not introduce any issues without noticing it... 🤞 -- but if we find anything, it could block/delay 3.5.0...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1531777179
Same issue. Trying again: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5655/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1534030108
13 tests failed -- `StreamsBrokerBounceTest` should be unrelated, but also `StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces`
Re-triggred to see if the same tests fails, or if it's flakyness: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5657/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1532305605
System test failed due to incorrect dev-version. Pushed a fix.
Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5656/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #13654:
URL: https://github.com/apache/kafka/pull/13654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ahuang98 commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "ahuang98 (via GitHub)" <gi...@apache.org>.
ahuang98 commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270012540
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
guessing it was removed because there were no references to it, I'll add it back when I raise a PR for more comprehensive upgrade tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270009709
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Here -- did we mean to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270108718
##########
tests/kafkatest/version.py:
##########
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Yes -- 3.6.0 is not released yet. We should only need it after 3.6.0 is out.
If you want to refer to current version it would be `DEV_VERSION` (ie, 3.6.0-SNAPSHOT).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530523163
Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5653/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530533230
> Nice catch
Well, rather embarrassing... I reviewed and merge the PR introducing the issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1535516492
Ok. Dug into this a little bit, and some test are broken, because KS is broken.
The original PR for https://issues.apache.org/jira/browse/KAFKA-13769 broke KS, but it also added the test regression using randomized `application.id`s and thus masked the error it introduced. The issue was reported later via https://issues.apache.org/jira/browse/KAFKA-14646 and we fixed it forward.
However, the fact remains that rolling bounce upgrades are broken for 2.4 - 3.0 release as "from_version". I updates this PR to disable the corresponding tests.
Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5658/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org