[GitHub] [iceberg] xingfanx commented on a diff in pull request #4821: AWS: handle certain glue exceptions as iceberg errors

[GitBox <gi...@apache.org>]

xingfanx commented on code in PR #4821:
URL: https://github.com/apache/iceberg/pull/4821#discussion_r877696474


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -128,6 +131,16 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
     } catch (software.amazon.awssdk.services.glue.model.AlreadyExistsException e) {
       throw new AlreadyExistsException(e,
           "Cannot commit %s because its Glue table already exists when trying to create one", tableName());
+    } catch (software.amazon.awssdk.services.glue.model.EntityNotFoundException e) {
+      throw new NotFoundException(e,
+              "Cannot commit %s because Glue cannot find the requested entity", tableName());

Review Comment:
   applied the code style xml and fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org