You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2007/02/08 21:41:20 UTC
Re: svn commit: r504982 - /incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
On 2/8/07, dblevins@apache.org <db...@apache.org> wrote:
> Author: dblevins
> Date: Thu Feb 8 10:00:26 2007
> New Revision: 504982
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=504982
> Log:
> skip naming installation if it should not be there
>
> Modified:
> incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
>
> Modified: incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
> URL: http://svn.apache.org/viewvc/incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java?view=diff&rev=504982&r1=504981&r2=504982
> ==============================================================================
> --- incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java (original)
> +++ incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Thu Feb 8 10:00:26 2007
> @@ -148,6 +148,8 @@
> }
>
> public static void installNaming() {
> + if (System.getProperty("duct tape") != null) return;
> +
Heh? Why's that necessary? Who would want the naming installation to be skipped?
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
Re: svn commit: r504982 - /incubator/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
Posted by David Blevins <da...@visi.com>.
On Feb 8, 2007, at 12:41 PM, Jacek Laskowski wrote:
> On 2/8/07, dblevins@apache.org <db...@apache.org> wrote:
>> Author: dblevins
>> Date: Thu Feb 8 10:00:26 2007
>> New Revision: 504982
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=504982
>> Log:
>> skip naming installation if it should not be there
>>
>> Modified:
>> incubator/openejb/trunk/openejb3/container/openejb-core/src/
>> main/java/org/apache/openejb/assembler/classic/Assembler.java
>>
>> Modified: incubator/openejb/trunk/openejb3/container/openejb-core/
>> src/main/java/org/apache/openejb/assembler/classic/Assembler.java
>> URL: http://svn.apache.org/viewvc/incubator/openejb/trunk/openejb3/
>> container/openejb-core/src/main/java/org/apache/openejb/assembler/
>> classic/Assembler.java?view=diff&rev=504982&r1=504981&r2=504982
>> =====================================================================
>> =========
>> --- incubator/openejb/trunk/openejb3/container/openejb-core/src/
>> main/java/org/apache/openejb/assembler/classic/Assembler.java
>> (original)
>> +++ incubator/openejb/trunk/openejb3/container/openejb-core/src/
>> main/java/org/apache/openejb/assembler/classic/Assembler.java Thu
>> Feb 8 10:00:26 2007
>> @@ -148,6 +148,8 @@
>> }
>>
>> public static void installNaming() {
>> + if (System.getProperty("duct tape") != null) return;
>> +
>
> Heh? Why's that necessary? Who would want the naming installation
> to be skipped?
We might be able to remove it now as I made a fix in Geronimo so that
when it sets itself as the naming implementation it "cements" it by
calling some jndi lookups, but yea it's not something you'd want to
skip in a standalone environment.
-David