[GitHub] [superset] betodealmeida commented on pull request #13519: fix: Fix for Teradata connection in SQL Lab

[GitBox <gi...@apache.org>]

betodealmeida commented on pull request #13519:
URL: https://github.com/apache/superset/pull/13519#issuecomment-853117336


   My suggestions for us to move forward are:
   
   1. Rebase the branch and force push it so we have only the relevant changes in the PR.
   2. Merge the logic of `_extract_limit_from_query_td` into `_extract_limit_from_query`.
   3. For `set_or_update_query_limit_td` we probably need to add a new method to the base engine spec with the logic from `set_or_update_query_limit`, and override the metadata in the Teradata spec.
   4. If after this there are still circular dependencies we can fix it in a few different ways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org