You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Matthew F. Dennis (JIRA)" <ji...@apache.org> on 2010/06/01 09:04:36 UTC
[jira] Created: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
cassandra cannot bootstrap when using DatacenterShardStrategy
-------------------------------------------------------------
Key: CASSANDRA-1147
URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7
Reporter: Matthew F. Dennis
Assignee: Matthew F. Dennis
Fix For: 0.7
If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874060#action_12874060 ]
Jonathan Ellis commented on CASSANDRA-1147:
-------------------------------------------
could we just make DSS return sum(dc replication for table) as RF(table), for now?
(CASSANDRA-1066 should resolve this eventually by allowing us to move datacenter.properties into cassandra.yaml, and drop the per-table RF for strategies that it doesn't make sense for)
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Attachment: (was: CASSANDRA-1147.patch3)
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Attachment: CASSANDRA-1147.patch2
patch2 against trunk r950215
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878630#action_12878630 ]
Jonathan Ellis commented on CASSANDRA-1147:
-------------------------------------------
please fix re-ordering imports incorrectly. correct order is
* java
* org.apache.commons
* org.apache.slf4j
* org.junit
* everything else alphabetically
(http://wiki.apache.org/cassandra/CodeStyle)
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2, CASSANDRA-1147.patch3
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Comment: was deleted
(was: CASSANDRA-1147.patch3 implements caching for all strategies)
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Attachment: CASSANDRA-1147.patch4
CASSANDRA-1147.patch4 follows coding convention for imports
(note: the patch produced by "svn diff" was not originally usable because of the line endings in RackAwareStrategyTest so dos2unix was run on the patch)
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2, CASSANDRA-1147.patch3, CASSANDRA-1147.patch4
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Attachment: CASSANDRA-1147.patch3
CASSANDRA-1147.patch3 implements caching for all strategies
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2, CASSANDRA-1147.patch3
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Attachment: CASSANDRA-1147.patch3
CASSANDRA-1147.patch3 implements caching and tests for all replication strategies
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2, CASSANDRA-1147.patch3
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-1147:
-----------------------------------------
Attachment: CASSANDRA-1147.patch
patch caches endpoints for getNaturalEndpoints (cleared on config or ring change) without requiring dcTokens/loadEndpoints and removes the need for CASSANDRA-1137
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875447#action_12875447 ]
Jonathan Ellis commented on CASSANDRA-1147:
-------------------------------------------
caching natural endpoints seems like something we should put in AbstractReplicationStrategy for everyone. what do you think?
(Given CASSANDRA-1014 I'm mildly excited about the opportunity to reduce the per-request garbage generated, by not rebuilding a fresh list every time.)
+ //is a new list required each time? (other strats do it)
+ //perhaps just an unmodifiable list?
yes, it's required, because it's going to be passed to sortByProximity.
+ total+=repFactor;
operator spacing please :)
+ System.out.println("endpoints: " + endpoints);
r/m this.
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch, CASSANDRA-1147.patch2
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878965#action_12878965 ]
Hudson commented on CASSANDRA-1147:
-----------------------------------
Integrated in Cassandra #466 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/466/])
avoid allowing endpoints computed from old token map to persist after clearCachedEndpoints. patch by mdennis and jbellis for CASSANDRA-1147
Fix bootstrap with DSS and add endpoint caching.
patch by mdennis and jbellis for CASSANDRA-1147
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: 0002-1147.txt, CASSANDRA-1147.patch, CASSANDRA-1147.patch2, CASSANDRA-1147.patch3, CASSANDRA-1147.patch4
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874032#action_12874032 ]
Matthew F. Dennis commented on CASSANDRA-1147:
----------------------------------------------
different methods. the assert is for grf(String dc, String table) and corresponds to datacenters.properties the override is for grf(String table) and corresponds to replication_factor in cassandra.yaml
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873983#action_12873983 ]
Jonathan Ellis commented on CASSANDRA-1147:
-------------------------------------------
how does
assert strategy.getReplicationFactor("DC1", table) == 3;
work when you're hardcoding it to 6 in the subclass?
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: CASSANDRA-1147.patch
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1147) cassandra cannot bootstrap when
using DatacenterShardStrategy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1147:
--------------------------------------
Attachment: 0002-1147.txt
Fix using rack as a key to datacenters map
Fix returning multiple copies of the same endpoint from DSS; refactored calculateNaturalEndpoints to return a Set to make it more clear that this is not allowed
simplified DSS.cNE and made it not put more replicas in a DC than are configured
Use NBHM instead of ConcurrentHM in ARS
Use map.clear instead of AtomicReference + creating a new map in ARS (clear is a very rare operation, better to make that a little slower in exchange for not having to do an extra, fenced dereference on the common ops)
Removed unused unregister method from IEPS
Removed interfaces with a single implementor (ARS)
Cleaned up formatting
> cassandra cannot bootstrap when using DatacenterShardStrategy
> -------------------------------------------------------------
>
> Key: CASSANDRA-1147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1147
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7
>
> Attachments: 0002-1147.txt, CASSANDRA-1147.patch, CASSANDRA-1147.patch2, CASSANDRA-1147.patch3, CASSANDRA-1147.patch4
>
>
> If C is configured to use DSS, the bootstrap process never completes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.