You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2008/09/12 11:39:45 UTC

[jira] Updated: (HARMONY-5982) [classlib] - serialVersionUID should be declared private

     [ https://issues.apache.org/jira/browse/HARMONY-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-5982:
------------------------------

    Attachment: HARMONY-5982.diff

the patch also fix files:
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/beancontext/BeanContextChildSupportTest.java
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/beancontext/BeanContextEventTest.java
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/beancontext/BeanContextMembershipEventTest.java
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/beancontext/BeanContextServiceAvailableEventTest.java
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/beancontext/BeanContextServiceRevokedEventTest.java
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/beancontext/BeanContextServicesSupportTest.java
beans/src/test/java/org/apache/harmony/beans/tests/java/beans/BeansTest.java
beans/src/test/support/java/org/apache/harmony/beans/tests/support/mock/MockAppletBean2.java
jndi/src/main/java/javax/naming/OperationNotSupportedException.java
luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/ObjectInputStreamTest.java

below files are interface, so needn't to be changed:
crypto/src/main/java/javax/crypto/interfaces/DHPrivateKey.java
crypto/src/main/java/javax/crypto/interfaces/DHPublicKey.java
crypto/src/main/java/javax/crypto/interfaces/PBEKey.java
crypto/src/main/java/javax/crypto/SecretKey.java
jndi/src/main/java/javax/naming/Name.java
rmi/src/main/java/java/rmi/server/RemoteRef.java
rmi/src/main/java/java/rmi/server/ServerRef.java
security/src/main/java/common/java/security/interfaces/DSAPrivateKey.java
security/src/main/java/common/java/security/interfaces/DSAPublicKey.java
security/src/main/java/common/java/security/interfaces/ECPrivateKey.java
security/src/main/java/common/java/security/interfaces/ECPublicKey.java
security/src/main/java/common/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java
security/src/main/java/common/java/security/interfaces/RSAPrivateCrtKey.java
security/src/main/java/common/java/security/interfaces/RSAPrivateKey.java
security/src/main/java/common/java/security/interfaces/RSAPublicKey.java
security/src/main/java/common/java/security/Key.java
security/src/main/java/common/java/security/PrivateKey.java
security/src/main/java/common/java/security/PublicKey.java

> [classlib] - serialVersionUID should be declared private
> --------------------------------------------------------
>
>                 Key: HARMONY-5982
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5982
>             Project: Harmony
>          Issue Type: Bug
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>            Assignee: Sean Qiu
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5982.diff
>
>
> There are lots of serialversionUID that are default visibility, they should be marked private.
> And I quickly reviewed all the serialversionUID, found below files' serialversionUID are not private:
> swing/src/main/java/common/javax/swing/text/html/parser/ContentModel.java
> jndi/src/main/java/javax/naming/AuthenticationException.java
> jndi/src/main/java/javax/naming/MalformedLinkException.java
> jndi/src/main/java/javax/naming/InvalidNameException.java
> jndi/src/main/java/javax/naming/SizeLimitExceededException.java
> jndi/src/main/java/javax/naming/CommunicationException.java
> jndi/src/main/java/javax/naming/LinkLoopException.java
> jndi/src/main/java/javax/naming/ServiceUnavailableException.java
> jndi/src/main/java/javax/naming/directory/BasicAttributes.java
> jndi/src/main/java/javax/naming/directory/Attribute.java
> jndi/src/main/java/javax/naming/directory/BasicAttribute.java
> jndi/src/main/java/javax/naming/NameAlreadyBoundException.java
> jndi/src/main/java/javax/naming/InterruptedNamingException.java
> jndi/src/main/java/javax/naming/ConfigurationException.java
> jndi/src/main/java/javax/naming/Name.java
> jndi/src/main/java/javax/naming/NoPermissionException.java
> jndi/src/main/java/javax/naming/NameNotFoundException.java
> jndi/src/main/java/javax/naming/AuthenticationNotSupportedException.java
> jndi/src/main/java/javax/naming/InsufficientResourcesException.java
> jndi/src/main/java/javax/naming/NotContextException.java
> jndi/src/main/java/javax/naming/ldap/LdapReferralException.java
> jndi/src/main/java/javax/naming/ldap/UnsolicitedNotificationEvent.java
> jndi/src/main/java/javax/naming/LimitExceededException.java
> jndi/src/main/java/javax/naming/RefAddr.java
> jndi/src/main/java/javax/naming/StringRefAddr.java
> jndi/src/main/java/javax/naming/LinkRef.java
> jndi/src/main/java/javax/naming/TimeLimitExceededException.java
> jndi/src/main/java/javax/naming/ContextNotEmptyException.java:34
> jndi/src/main/java/javax/naming/NoInitialContextException.java
> jndi/src/main/java/javax/naming/spi/ResolveResult.java
> jndi/src/main/java/javax/naming/PartialResultException.java
> crypto/src/main/java/javax/crypto/SecretKey.java
> crypto/src/main/java/javax/crypto/interfaces/DHPublicKey.java
> crypto/src/main/java/javax/crypto/interfaces/PBEKey.java
> crypto/src/main/java/javax/crypto/interfaces/DHPrivateKey.java
> security/src/main/java/common/java/security/PublicKey.java
> security/src/main/java/common/java/security/PrivateKey.java
> security/src/main/java/common/java/security/interfaces/RSAPublicKey.java
> security/src/main/java/common/java/security/interfaces/RSAPrivateCrtKey.java
> security/src/main/java/common/java/security/interfaces/ECPrivateKey.java
> security/src/main/java/common/java/security/interfaces/DSAPublicKey.java
> security/src/main/java/common/java/security/interfaces/RSAPrivateKey.java
> security/src/main/java/common/java/security/interfaces/DSAPrivateKey.java
> security/src/main/java/common/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java
> security/src/main/java/common/java/security/interfaces/ECPublicKey.java
> security/src/main/java/common/java/security/Key.java
> print/src/main/java/windows/org/apache/harmony/x/print/GDIClient.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/javax/print/attribute/AttributeSetUtilities.java
> print/src/main/java/common/org/apache/harmony/x/print/attributes/PPDMediaSizeName.java
> print/src/main/java/common/org/apache/harmony/x/print/attributes/MediaMargins.java
> print/src/main/java/common/org/apache/harmony/x/print/ipp/IppAttributeGroup.java
> print/src/main/java/common/org/apache/harmony/x/print/ipp/IppAttributeGroupSet.java
> print/src/main/java/common/org/apache/harmony/x/print/ipp/IppException.java
> print/src/main/java/common/org/apache/harmony/x/print/ipp/util/IppMimeType.java
> print/src/main/java/common/org/apache/harmony/x/print/MimeType.java
> print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java
> beans/src/main/java/java/beans/beancontext/BeanContextServiceAvailableEvent.java
> beans/src/main/java/java/beans/beancontext/BeanContextSupport.java
> beans/src/main/java/java/beans/beancontext/BeanContextSupport.java
> beans/src/main/java/java/beans/beancontext/BeanContextEvent.java
> beans/src/main/java/java/beans/beancontext/BeanContextServicesSupport.java
> beans/src/main/java/java/beans/beancontext/BeanContextServicesSupport.java
> beans/src/main/java/java/beans/beancontext/BeanContextServiceRevokedEvent.java
> beans/src/main/java/java/beans/IntrospectionException.java
> rmi/src/main/java/java/rmi/server/RemoteRef.java
> rmi/src/main/java/java/rmi/server/ServerRef.java
> luni/src/main/java/java/util/InputMismatchException.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.