[GitHub] [solr] janhoy commented on a diff in pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb

[GitBox <gi...@apache.org>]

janhoy commented on code in PR #1084:
URL: https://github.com/apache/solr/pull/1084#discussion_r998545994


##########
solr/docker/templates/Dockerfile.official.header.template:
##########
@@ -85,5 +85,6 @@ RUN set -ex; \
   { command -v gpgconf; gpgconf --kill all || :; }; \
   rm -r "$GNUPGHOME"; \
   tar -C /opt --extract --preserve-permissions --file "/opt/solr-$SOLR_VERSION.tgz"; \
-  rm "/opt/solr-$SOLR_VERSION.tgz"*;
+  rm "/opt/solr-$SOLR_VERSION.tgz"*; \
+  apt -y remove wget gpg dirmngr && apt -y autoremove;

Review Comment:
   No need to remove wget here when we install it again later. Use `apt-get` instead of `apt` for consistency within the file.
   ```suggestion
     apt-get -y remove gpg dirmngr && apt-get -y autoremove;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org