You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:53:05 UTC

[GitHub] [fineract] xurror opened a new pull request #1020: FINERACT-1021 - Update to JUnit 5

xurror opened a new pull request #1020:
URL: https://github.com/apache/fineract/pull/1020


   [FINERACT-1021](https://issues.apache.org/jira/browse/FINERACT-1021)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] xurror commented on pull request #1020: [WIP]FINERACT-1021 - Update to JUnit 5

Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1020:
URL: https://github.com/apache/fineract/pull/1020#issuecomment-643053878


   @vorburger @awasum good for you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1020: FINERACT-1021 - Update to JUnit 5

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1020:
URL: https://github.com/apache/fineract/pull/1020#issuecomment-643769384


   ==> #1054


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #1020: FINERACT-1021 - Update to JUnit 5

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1020:
URL: https://github.com/apache/fineract/pull/1020


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger closed pull request #1020: FINERACT-1021 - Update to JUnit 5

Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #1020:
URL: https://github.com/apache/fineract/pull/1020


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1020: FINERACT-1021 - Update to JUnit 5

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1020:
URL: https://github.com/apache/fineract/pull/1020#issuecomment-643759528


   Wait a second - this disabled all tests!!!!! :sob: 
   
   Both `./gradlew test` and `./gradlew integrationTest` don't do anything, anymore after I merge this.
   
   We therefore either have to revert this ASAP, or fix it today... sorry & thanks for understanding.
   
   The Revert is non-trivial because I've meanwhile merged other PRs.
   
   @xurror @percyashu @thesmallstar @awasum @ptuomola would one of you like to look into how to make tests run? I'm guessing the Gradle needs some sort of configuration change to run JUnit 5...
   
   This is now blocking #943 ... :disappointed: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org