[GitHub] [shardingsphere] yangsen00 commented on a diff in pull request #25680: Rename SelectStatementContext#isSameGroupByAndOrderByItems to isGroupByStartsWithOrderByItems(#25414)

["yangsen00 (via GitHub)" <gi...@apache.org>]

yangsen00 commented on code in PR #25680:
URL: https://github.com/apache/shardingsphere/pull/25680#discussion_r1199998699


##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementContext.java:
##########
@@ -294,8 +296,20 @@ private String getOrderItemText(final TextOrderByItemSegment orderByItemSegment)
      *
      * @return group by and order by sequence is same or not
      */
-    public boolean isSameGroupByAndOrderByItems() {
-        return !groupByContext.getItems().isEmpty() && groupByContext.getItems().equals(orderByContext.getItems());
+    public boolean isGroupByStartsWithOrderByItems() {

Review Comment:
   Of course.but Can you give a Can you give an example？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org