You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 17:01:44 UTC
[GitHub] [airflow] Acehaidrey opened a new pull request #20112: Add td_format function and apply to Views duration column for better human readability
Acehaidrey opened a new pull request #20112:
URL: https://github.com/apache/airflow/pull/20112
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-993500877
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-991158297
@bbovenzi mind looking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-990390955
Your local code is different from the code in the PR. The error is pretty straightforward; `Union` is not imported in `timezone.py`, so Python errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20112:
URL: https://github.com/apache/airflow/pull/20112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-994078771
Thanks for the discussion. I've just made some updates here, waiting for tests to pass then will burden you with review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-993476639
> @bbovenzi when you recommend that format, `01:00:02` that is what it currently is. That is how the timedeltas look right now if I'm not mistaken. Unless you are looking for something that goes 5d:4h:32m:45s is that what you're recommending?
>
> I'd like to get this in as soon as possible this week so if you don't mind quickly iterating with me to complete the ask.
`01:00:02` vs '1 hour, 2 seconds' (this is what the PR does currently, no?). I think that is what Brent is suggesting.
I am fine with either, I don't have a strong opinion on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-990356864
@uranusjr - I don't know what is going on with my build but these import failures of Union I don't have locally. I've tried a few things but can't get this happening on mine. Mind verifying if you apply this change do you see same thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-993005073
@bbovenzi when you recommend that format, `01:00:02` that is what it currently is. That is how the timedeltas look right now if I'm not mistaken. Unless you are looking for something that goes 5d:4h:32m:45s is that what you're recommending?
I'd like to get this in as soon as possible this week so if you don't mind quickly iterating with me to complete the ask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-993478750
>One open question is, is it preferred to make it optionable to apply this change to display the duration as this readable way vs the original timedelta way.
hmm, maybe a config or a profile setting -- not sure @bbovenzi @ryanahamilton thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-989561127
@uranusjr sorry I didn't realize it created PR already. Working on it now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-990391612
@uranusjr oh my God, I am sorry, yes locally I have it imported. But I also merged the code. Let me pull it down. Something is off in my local -
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-988570543
Need to fix many errors in linters and tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #20112:
URL: https://github.com/apache/airflow/pull/20112#issuecomment-993624061
Good question. Let's go for `5d:4h:32m:45s` and I can update other parts of the app in a subsequent pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org