You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/24 13:02:20 UTC
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2294: feat(http-logger): support for specified the log formats via admin API
juzhiyuan commented on a change in pull request #2294:
URL: https://github.com/apache/apisix/pull/2294#discussion_r494297836
##########
File path: bin/apisix
##########
@@ -1025,7 +1025,7 @@ local function init_etcd(show_output)
for _, dir_name in ipairs({"/routes", "/upstreams", "/services",
"/plugins", "/consumers", "/node_status",
"/ssl", "/global_rules", "/stream_routes",
- "/proto"}) do
+ "/proto", "/plugin_metadata"}) do
Review comment:
I would recommend using `/plugins/{name}/metadat` in a RESTful way if this PR is needed..
##########
File path: bin/apisix
##########
@@ -1025,7 +1025,7 @@ local function init_etcd(show_output)
for _, dir_name in ipairs({"/routes", "/upstreams", "/services",
"/plugins", "/consumers", "/node_status",
"/ssl", "/global_rules", "/stream_routes",
- "/proto"}) do
+ "/proto", "/plugin_metadata"}) do
Review comment:
I would recommend using `/plugins/{name}/metadata` in a RESTful way if this PR is needed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org