You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/07 07:58:00 UTC

[GitHub] [flink] NicoK commented on a change in pull request #12835: [hotfix] Fix the typo when describing checkpointed data size

NicoK commented on a change in pull request #12835:
URL: https://github.com/apache/flink/pull/12835#discussion_r450677726



##########
File path: docs/monitoring/checkpoint_monitoring.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
 - **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
 - **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
 - **End to End Duration**: The duration from the trigger timestamp until the latest acknowledgement (or n/a if no acknowledgement received yet). This end to end duration for a complete checkpoint is determined by the last subtask that acknowledges the checkpoint. This time is usually larger than single subtasks need to actually checkpoint the state.
-- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value would be the delta delta checkpointed data if incremetnal checkpoint is on.
+- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value would be the delta checkpointed data if incremetnal checkpoint is on.

Review comment:
       ```suggestion
   - **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value represents the delta of the checkpointed data if incremental checkpointing is on.
   ```

##########
File path: docs/monitoring/checkpoint_monitoring.zh.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
 - **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
 - **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
 - **End to End Duration**: The duration from the trigger timestamp until the latest acknowledgement (or n/a if no acknowledgement received yet). This end to end duration for a complete checkpoint is determined by the last subtask that acknowledges the checkpoint. This time is usually larger than single subtasks need to actually checkpoint the state.
-- **Checkpointed Data Size**: The state size over all acknowledged subtasks.
+- **Checkpointed Data Size**: The state size over all acknowledged subtasks. This value would be the delta checkpointed data if incremetnal checkpoint is on.

Review comment:
       ```suggestion
   - **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value represents the delta of the checkpointed data if incremental checkpointing is on.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org