You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/19 14:15:43 UTC
[GitHub] [airflow] jedcunningham opened a new issue #15434: KubernetesPodOperator name randomization
jedcunningham opened a new issue #15434:
URL: https://github.com/apache/airflow/issues/15434
**Description**
`KubernetesPodOperator.name` randomization should be decoupled from the way the name is set. Currently `name` is only randomized if the `name` kwarg is used. However, one could also want name randomization when a name is set in a `pod_template_file` or `full_pod_spec`.
Move the name randomization feature behind a new feature flag, defaulted to True.
**Related Issues**
#14167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi edited a comment on issue #15434: KubernetesPodOperator name randomization
Posted by GitBox <gi...@apache.org>.
ferruzzi edited a comment on issue #15434:
URL: https://github.com/apache/airflow/issues/15434#issuecomment-947023942
I can take this one on.
To double-check my understanding, can you confirm this is the desired behavior:
| name | randomize_name_suffix | pod_template_file or full_pod_spec | result |
|----------|-----------------------|------------------------------------|----------------------------------------------------------|
| provided | True | False | name.{random_suffix} |
| provided | False | False | name (no suffix) |
| provided | True | True | name.{random_suffix} |
| provided | False | True | name (no suffix) |
| None | True | False | exception |
| None | False | False | exception |
| None | True | True | get base name from spec or file and append random suffix |
| None | False | True | use the name as provided in the spec or file |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on issue #15434: KubernetesPodOperator name randomization
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on issue #15434:
URL: https://github.com/apache/airflow/issues/15434#issuecomment-947023942
I can take this one on.
To double-check my understanding, can you confirm this is the desired behavior:
| name | randomize_name_suffix | pod_template_file or full_pod_spec | result |
|----------|-----------------------|------------------------------------|----------------------------------------------------------|
| provided | True | False | name-{random_suffix} |
| provided | False | False | name (no suffix) |
| provided | True | True | name-{random_suffix} |
| provided | False | True | name (no suffix) |
| None | True | False | exception |
| None | False | False | exception |
| None | True | True | get base name from spec or file and append random suffix |
| None | False | True | return None |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #15434: KubernetesPodOperator name randomization
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #15434:
URL: https://github.com/apache/airflow/issues/15434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi edited a comment on issue #15434: KubernetesPodOperator name randomization
Posted by GitBox <gi...@apache.org>.
ferruzzi edited a comment on issue #15434:
URL: https://github.com/apache/airflow/issues/15434#issuecomment-947023942
I can take this one on.
[[EDIT: I was totally overthinking it, I got this.]]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi edited a comment on issue #15434: KubernetesPodOperator name randomization
Posted by GitBox <gi...@apache.org>.
ferruzzi edited a comment on issue #15434:
URL: https://github.com/apache/airflow/issues/15434#issuecomment-947023942
I can take this one on.
[[EDIT: Removed question, I was totally overthinking it. I got this.]]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org