You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/28 01:05:52 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #898: Juzhiyuan/feat plugin

juzhiyuan opened a new pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   fix #815 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742315027


   > LGTM except more information about icons.
   > 
   > It would be better to add a desc about the relationship between existing icons and their names or show the project address of iconfont, when users want to add an icon, they can apply for joining ^_^
   
   currently, IconFont needs one account to manage those icons 😂 This issue is not urgent but need to be resolved.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818123



##########
File path: web/src/components/Plugin/data.tsx
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';

Review comment:
       @nic-chen @membphis Do we support fetching plugin list with the category?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r532323097



##########
File path: web/src/components/Plugin/CodeMirrorDrawer.tsx
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React, { useRef } from 'react';
+import { Drawer, Button, notification } from 'antd';
+import CodeMirror from '@uiw/react-codemirror';
+
+type Props = {
+  visible?: boolean;
+  data?: object;
+  readonly?: boolean;
+  onClose?: () => void;
+  onSubmit?: (data: object) => void;
+};
+
+const CodeMirrorDrawer: React.FC<Props> = ({
+  visible = false,
+  readonly = false,
+  data = {},
+  onClose,
+  onSubmit,
+}) => {
+  const ref = useRef<any>(null);
+  return (
+    <Drawer
+      visible={visible}
+      width={500}
+      onClose={onClose}
+      footer={
+        !readonly && (
+          <div style={{ display: 'flex', justifyContent: 'space-between' }}>
+            <Button onClick={onClose}>Cancel</Button>

Review comment:
       i18n would be resolved totally in 2.3 😂 use English currently




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742221067


   Hi @liuxiran @bzp2010 Kindly review this PR when you have time :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-741864419


   CI failed due to #998 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818150



##########
File path: web/src/components/Plugin/service.ts
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { JSONSchema7 } from 'json-schema';
+import { omit } from 'lodash';
+import { request } from 'umi';

Review comment:
       extra line is needed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r532055377



##########
File path: web/src/components/Plugin/data.tsx
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';

Review comment:
       not sure, I just want to fetch plugin list with category.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735022395


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=h1) Report
   > Merging [#898](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=desc) (e769114) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/277ae594b213c1c0bfb9aa0d387622cc9c65a6cc?el=desc) (277ae59) will **decrease** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/898/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #898      +/-   ##
   ==========================================
   - Coverage   43.03%   42.95%   -0.08%     
   ==========================================
     Files          18       18              
     Lines        1271     1271              
   ==========================================
   - Hits          547      546       -1     
   - Misses        632      633       +1     
     Partials       92       92              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/898/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.28% <0.00%> (-0.66%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=footer). Last update [277ae59...e769114](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r532234642



##########
File path: web/src/components/Plugin/CodeMirrorDrawer.tsx
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React, { useRef } from 'react';
+import { Drawer, Button, notification } from 'antd';
+import CodeMirror from '@uiw/react-codemirror';
+
+type Props = {
+  visible?: boolean;
+  data?: object;
+  readonly?: boolean;
+  onClose?: () => void;
+  onSubmit?: (data: object) => void;
+};
+
+const CodeMirrorDrawer: React.FC<Props> = ({
+  visible = false,
+  readonly = false,
+  data = {},
+  onClose,
+  onSubmit,
+}) => {
+  const ref = useRef<any>(null);
+  return (
+    <Drawer
+      visible={visible}
+      width={500}
+      onClose={onClose}
+      footer={
+        !readonly && (
+          <div style={{ display: 'flex', justifyContent: 'space-between' }}>
+            <Button onClick={onClose}>Cancel</Button>

Review comment:
       i18n would be better




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818067



##########
File path: web/src/components/Plugin/IconFont.tsx
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { createFromIconfontCN } from '@ant-design/icons';
+
+// NOTE: Icons from AliCDN https://www.iconfont.cn/manage/index
+const IconFont = createFromIconfontCN({
+  scriptUrl: '//at.alicdn.com/t/font_2088089_a3klmsocd15.js',

Review comment:
       Let's use local files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735022395


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=h1) Report
   > Merging [#898](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=desc) (cf9912a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/277ae594b213c1c0bfb9aa0d387622cc9c65a6cc?el=desc) (277ae59) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/898/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #898   +/-   ##
   =======================================
     Coverage   43.03%   43.03%           
   =======================================
     Files          18       18           
     Lines        1271     1271           
   =======================================
     Hits          547      547           
     Misses        632      632           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=footer). Last update [277ae59...cf9912a](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735045558


   The frontend has completed, this PR is waiting for the manager-api to support this issue https://github.com/apache/apisix-dashboard/issues/495


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735033298


   waiting for manager-api to support `disable` property.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742315027


   > LGTM except more information about icons.
   > 
   > It would be better to add a desc about the relationship between existing icons and their names or show the project address of iconfont, when users want to add an icon, they can apply for joining ^_^
   
   currently, IconFont needs one account to manage those icons 😂


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r532009018



##########
File path: web/src/components/Plugin/data.tsx
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';

Review comment:
        manager-api doesn't support fetching Metadata yet.
   but why we need metadata here ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818598



##########
File path: web/src/components/Plugin/data.tsx
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';

Review comment:
       ![image](https://user-images.githubusercontent.com/2106987/100491073-eba24f80-315b-11eb-8768-855bceff7289.png)
   
   I found this API: https://github.com/apache/apisix/blob/master/doc/admin-api.md#plugin-metadata
   
   It seems that the manager-api doesn't support fetching Metadata 🤔 not urgent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742221067


   Hi @liuxiran @bzp2010 Kindly review this PR when you have time 💯 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735022395


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=h1) Report
   > Merging [#898](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=desc) (44ca4f2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/277ae594b213c1c0bfb9aa0d387622cc9c65a6cc?el=desc) (277ae59) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/898/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #898   +/-   ##
   =======================================
     Coverage   43.03%   43.03%           
   =======================================
     Files          18       18           
     Lines        1271     1271           
   =======================================
     Hits          547      547           
     Misses        632      632           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=footer). Last update [277ae59...44ca4f2](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735022395


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=h1) Report
   > Merging [#898](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=desc) (8b92a1d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c574813eea82edcd6d95a2ea0f8857b736049717?el=desc) (c574813) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/898/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #898   +/-   ##
   =======================================
     Coverage   43.49%   43.49%           
   =======================================
     Files          18       18           
     Lines        1299     1299           
   =======================================
     Hits          565      565           
     Misses        642      642           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=footer). Last update [c574813...8b92a1d](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r539421834



##########
File path: web/src/components/Plugin/IconFont.tsx
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { createFromIconfontCN } from '@ant-design/icons';
+
+// NOTE: Icons from AliCDN https://www.iconfont.cn/manage/index
+const IconFont = createFromIconfontCN({
+  scriptUrl: '//at.alicdn.com/t/font_2088089_a3klmsocd15.js',

Review comment:
       https://www.iconfont.cn/help/detail?spm=a313x.7781069.1998910419.d8cf4382a&helptype=code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org