You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/06 13:42:07 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #499: Simplifying Deploy VM Wizard
davidjumani opened a new pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499
Fixes #490
Fixes #491
- Moves Affinity Group selection to Details
- Sets the minimum of the root disk size sider to the template size
- Adds a switch to show / hide details
- Adds a switch to show / hide root disk size slider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654257238
@PaulAngus Looks good ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654265279
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654831592
Boot type, etc options are gone @davidjumani
The advanced step looks weird, instead how about we move it to the very end, still have the swtich to show/hide those options? What do you think @PaulAngus ?
@utchoang can you review and test this as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654741832
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654265649
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655268944
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654746420
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2239)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#discussion_r451268939
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -89,12 +89,18 @@
:selected="tabKey"
:loading="loading.templates"
:preFillContent="dataPreFill"
- @update-template-iso="updateFieldValue"
- ></template-iso-selection>
+ @update-template-iso="updateFieldValue" />
+ <span>
+ {{ $t('Override root disk size') }}
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654246706
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655254419
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655249377
Okay we're doing hypervisor specific fields now, will test and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654741508
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654247324
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655268599
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654270299
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2224)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654611424
@davidjumani on the override root disk side can you remove the slider; so just the input and are we checking that size input is great than the size of template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655254730
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654850324
They aren't visible since we're using simulator. Tested it on a VMware setup @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654884758
David demo'd it to me @rhtyd, I thought that it did the job. I imagine there will be a lot of little tweaks we can make in future. but this iteration seemed a lot cleaner to me, so I gave it a thumbsup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655271181
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2250)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-655257137
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2249)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #499: vm: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#discussion_r451266199
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -89,12 +89,18 @@
:selected="tabKey"
:loading="loading.templates"
:preFillContent="dataPreFill"
- @update-template-iso="updateFieldValue"
- ></template-iso-selection>
+ @update-template-iso="updateFieldValue" />
+ <span>
+ {{ $t('Override root disk size') }}
Review comment:
@davidjumani Can you fix translation/key label usage across views (see locales/en.json to pick the keys, all lowercase)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #499: Simplifying Deploy VM Wizard
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #499:
URL: https://github.com/apache/cloudstack-primate/pull/499#issuecomment-654252304
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/499 (JID-2223)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org