You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2023/05/11 09:54:56 UTC
[GitHub] [cloudstack-documentation] vishesh92 opened a new pull request, #315: CKS: Add documentation for unmanaged kubernetes cluster
vishesh92 opened a new pull request, #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315
Depends on https://github.com/apache/cloudstack/pull/7515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] vishesh92 commented on a diff in pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#discussion_r1246441023
##########
source/plugins/cloudstack-kubernetes-service.rst:
##########
@@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be
createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input,
- **name** (name for the Kubernetes cluster; Required)
-- **description** (description for the Kubernetes cluster; Required)
+- **description** (description for the Kubernetes cluster)
- **zoneid** (availability zone in which Kubernetes cluster to be launched; Required)
-- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required)
-- **serviceofferingid** (the ID of the service offering for the virtual machines in the cluster; Required)
+- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required for CloudManaged clusters)
Review Comment:
I have moved `clustertype` parameter before `kubernetesversionid`. Is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1563817399
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/315. (QA-JID 79)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1563816836
@vishesh92 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] vishesh92 commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1563816028
@blueorangutan docbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#discussion_r1224018203
##########
source/plugins/cloudstack-kubernetes-service.rst:
##########
@@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be
createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input,
- **name** (name for the Kubernetes cluster; Required)
-- **description** (description for the Kubernetes cluster; Required)
+- **description** (description for the Kubernetes cluster)
Review Comment:
the png still shows the red star for required . can you update that as well?
##########
source/plugins/cloudstack-kubernetes-service.rst:
##########
@@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be
createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input,
- **name** (name for the Kubernetes cluster; Required)
-- **description** (description for the Kubernetes cluster; Required)
+- **description** (description for the Kubernetes cluster)
- **zoneid** (availability zone in which Kubernetes cluster to be launched; Required)
-- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required)
-- **serviceofferingid** (the ID of the service offering for the virtual machines in the cluster; Required)
+- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required for CloudManaged clusters)
Review Comment:
is "CloudManaged" the right term? we could be looking at other SDI managed clusters as well and these would not be CloudManaged from our perspective. I think "CloudStack managed" would be a better term.
##########
source/plugins/cloudstack-kubernetes-service.rst:
##########
@@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be
createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input,
- **name** (name for the Kubernetes cluster; Required)
-- **description** (description for the Kubernetes cluster; Required)
+- **description** (description for the Kubernetes cluster)
- **zoneid** (availability zone in which Kubernetes cluster to be launched; Required)
-- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required)
-- **serviceofferingid** (the ID of the service offering for the virtual machines in the cluster; Required)
+- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required for CloudManaged clusters)
Review Comment:
addendum I see that the term is explained further on. I think it should be explained at first use. (not sure if we have a glosary this would fit into)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1617539952
ping @vishesh92 @DaanHoogland @Pearl1594 if you'd advise on the review thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1612816377
@vishesh92 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1611148493
@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1611147315
ping @DaanHoogland @weizhouapache @Pearl1594 - request for review
@blueorangutan docbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud merged pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1611149556
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/315. (QA-JID 88)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1612818900
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/315. (QA-JID 89)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] vishesh92 commented on pull request #315: CKS: Add documentation for unmanaged kubernetes cluster
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #315:
URL: https://github.com/apache/cloudstack-documentation/pull/315#issuecomment-1612814821
@blueorangutan docbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org