[GitHub] anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.

[GitBox <gi...@apache.org>]

anirudhacharya commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET] Fix Maxpool and BatchNorm operator.
URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174645527
 
 

 ##########
 File path: python/mxnet/contrib/onnx/_import/import_onnx.py
 ##########
 @@ -126,13 +130,22 @@ def from_onnx(self, graph):
                     len(node.output), len(mxnet_sym.list_outputs()), op_name))
             for k, i in zip(list(node.output), range(len(node.output))):
                 self._nodes[k] = mxnet_sym[i]
+
+            # splitting params into args and aux params
+            for args in mxnet_sym.list_arguments():
+                if args in self._params:
+                    argDict.update({args: nd.array(self._params[args])})
+            for aux in mxnet_sym.list_auxiliary_states():
+                if aux in self._params:
 
 Review comment:
   Same comment as above in line 136

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services