You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/02 06:11:09 UTC

[GitHub] [incubator-echarts] yikuangli opened a new pull request #11965: fix(Markpoint): MarkPoint position with stack line/bar. Close #11535

yikuangli opened a new pull request #11965: fix(Markpoint): MarkPoint position with stack line/bar. Close #11535
URL: https://github.com/apache/incubator-echarts/pull/11965
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   Fixed issue where in the charts contain stacked data, the markpoint's position is not correct.
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   
   
   ### Fixed issues
   #11535 
   #11616 
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   The max,min,avg marker in the stacked bar or line graph with stacked data is misplaced.
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   ![image](https://user-images.githubusercontent.com/3286517/71653604-57392e00-2cfb-11ea-98b2-0b311d40ad3b.png)
   ![image](https://user-images.githubusercontent.com/3286517/71653644-9e272380-2cfb-11ea-9f9e-943deb12d796.png)
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   Changed markerTypeCalculatorWithExtent function in the markerHelper, let it always use the stacked data(if they have stack) to calculate marker's coordinate, and get the value from the original data.
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   ![image](https://user-images.githubusercontent.com/3286517/71653725-11309a00-2cfc-11ea-8773-65c2905c54a3.png)
   ![image](https://user-images.githubusercontent.com/3286517/71653681-ca42a480-2cfb-11ea-93a4-83fb4649d9dc.png)
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #11965: fix(Markpoint): MarkPoint position with stack line/bar. Close #11535

Posted by GitBox <gi...@apache.org>.

pissang merged pull request #11965: fix(Markpoint): MarkPoint position with stack line/bar. Close #11535
URL: https://github.com/apache/incubator-echarts/pull/11965
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org