[GitHub] [pulsar] michaeljmarshall opened a new pull request #10272: [Cursor] add return statement to exit asyncMarkDelete early on failure

[GitBox <gi...@apache.org>]

michaeljmarshall opened a new pull request #10272:
URL: https://github.com/apache/pulsar/pull/10272


   ### Motivation
   
   In reading through the message expiration code, I noticed that there is a case where we call `markDeleteFailed` on a callback, but don't subsequently return from the method.
   
   For background, any other time we call the `markDeleteFailed` method, we either call return or exit the method because it is part of a callback.
   
   ### Verifying this change
   
   None. I think this change is obvious enough that it doesn't require any validation. Please let me know if more validation is required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10272: [Cursor] add return statement to exit asyncMarkDelete early on failure

[GitBox <gi...@apache.org>]

merlimat merged pull request #10272:
URL: https://github.com/apache/pulsar/pull/10272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org