You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/11 09:38:52 UTC

[GitHub] brooklyn-server pull request #412: Fix integration tests in brooklyn-server

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/412#discussion_r87560722
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/entity/AbstractApplicationLegacyTest.java ---
    @@ -92,8 +94,11 @@ public void testStartAndStopUnmanagedAppAutomanagesTheAppAndChildren() throws Ex
             assertTrue(Entities.isManaged(app2));
             assertTrue(Entities.isManaged(child));
             assertEquals(child.getCallHistory(), ImmutableList.of("start"));
    -        assertEquals(mgmt.getEntityManager().getEntity(app2.getId()), app2);
    --- End diff --
    
    Wow, that's a really interesting error (that it used to pass because of `AbstractEntity.equals` matching on `o == selfProxy`, because `this.selfProxy` was null!). Well found and fixed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---