You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by John Speidel <js...@hortonworks.com> on 2016/05/14 00:59:11 UTC

Review Request 47382: ATLAS-491 : Business Catalog API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/
-----------------------------------------------------------

Review request for atlas and Hemanth Yamijala.


Bugs: ATLAS-491
    https://issues.apache.org/jira/browse/ATLAS-491


Repository: atlas


Description
-------

Initial implementation of Catalog API.

Known Issues/Limitations:
- No update/delete support for taxonomies/terms
  -- this will be added next week
- Some gaps in test coverage
  - Need more in-depth test coverage that exercise the generated gremlin pipeline
- some refactoring should still be done espcecially in the 'query' package
- need to add more logging
- need to finish some javadoc


Diffs
-----

  catalog/pom.xml PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
  pom.xml 5e2871e 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
  repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
  server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
  webapp/pom.xml de48c15 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml f0b606e 

Diff: https://reviews.apache.org/r/47382/diff/


Testing
-------

Ran all existing unit tests and added new tests.


Thanks,

John Speidel

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:17 a.m., Hemanth Yamijala wrote:
> > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, line 35
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383499#file1383499line35>
> >
> >     Trying to access these resources with master is giving me this exception:
> >     
> >     ======
> >     javax.servlet.ServletException: Unable to find Atlas Resource corresponding to : v1
> >     	at org.apache.atlas.authorize.AtlasAuthorizationUtils.getAtlasResourceType(AtlasAuthorizationUtils.java:112)
> >         
> >     ======
> >     Changes are required in Atlas authorization module to allow these new resources.

ok, I will look into what changes are needed in AtlasAuthorizationUtils.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133325
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:17 a.m., Hemanth Yamijala wrote:
> >

ok


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133325
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133325
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java (line 35)
<https://reviews.apache.org/r/47382/#comment197633>

    Trying to access these resources with master is giving me this exception:
    
    ======
    javax.servlet.ServletException: Unable to find Atlas Resource corresponding to : v1
    	at org.apache.atlas.authorize.AtlasAuthorizationUtils.getAtlasResourceType(AtlasAuthorizationUtils.java:112)
        
    ======
    Changes are required in Atlas authorization module to allow these new resources.


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383456#file1383456line37>
> >
> >     If I understood this correctly, the basepipe for the Gremlin search for entities begins by trying to identify all entity vertices (by virtue of using the full text search property that is common to all vertices). This would still be a huge result set to begin with, no?
> 
> John Speidel wrote:
>     This is currently the only way to identify an entity vertex with the current database model.  It is a requirement to be able to search all entity types and to be able to apply tags to entities across types. So, we need to be able to get all of the entity vertices, which is the set that would be returned from the base query. The biggest issue with using this field to determine the entity set is that it isn't indexed.  Also, the query starts with V(), which is all vertices in the graph but this doesn't result in all vertices being returned but instead adds them to the pipeline interator.  
>     
>     That being said, there are lots of improvements that can be made to improve query performance.  This would include, changes to the database model so that we knew the propery names ahead of time so that we could use an index instead of a filter.  Also, one optimization that I was going to add which didn't make it in was to use the type if it was provided so that indexes could be used as mentioned above.  For now, I don't think that we can improve on this.
> 
> Hemanth Yamijala wrote:
>     I thought we do index the ENTITY_TEXT_PROPERTY_KEY. This is done in GraphBackedSearchIndexer.createFullTextIndex. Please see comment below on search and we can probably get this in and open follow-up JIRAs to fix.

Being tracked by: https://issues.apache.org/jira/browse/ATLAS-807


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133332
-----------------------------------------------------------


On May 17, 2016, 10:41 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:41 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   distro/src/conf/policy-store.txt b072b49 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
>   webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.

> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383456#file1383456line37>
> >
> >     If I understood this correctly, the basepipe for the Gremlin search for entities begins by trying to identify all entity vertices (by virtue of using the full text search property that is common to all vertices). This would still be a huge result set to begin with, no?
> 
> John Speidel wrote:
>     This is currently the only way to identify an entity vertex with the current database model.  It is a requirement to be able to search all entity types and to be able to apply tags to entities across types. So, we need to be able to get all of the entity vertices, which is the set that would be returned from the base query. The biggest issue with using this field to determine the entity set is that it isn't indexed.  Also, the query starts with V(), which is all vertices in the graph but this doesn't result in all vertices being returned but instead adds them to the pipeline interator.  
>     
>     That being said, there are lots of improvements that can be made to improve query performance.  This would include, changes to the database model so that we knew the propery names ahead of time so that we could use an index instead of a filter.  Also, one optimization that I was going to add which didn't make it in was to use the type if it was provided so that indexes could be used as mentioned above.  For now, I don't think that we can improve on this.

I thought we do index the ENTITY_TEXT_PROPERTY_KEY. This is done in GraphBackedSearchIndexer.createFullTextIndex. Please see comment below on search and we can probably get this in and open follow-up JIRAs to fix.


- Hemanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133332
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383456#file1383456line37>
> >
> >     If I understood this correctly, the basepipe for the Gremlin search for entities begins by trying to identify all entity vertices (by virtue of using the full text search property that is common to all vertices). This would still be a huge result set to begin with, no?

This is currently the only way to identify an entity vertex with the current database model.  It is a requirement to be able to search all entity types and to be able to apply tags to entities across types. So, we need to be able to get all of the entity vertices, which is the set that would be returned from the base query. The biggest issue with using this field to determine the entity set is that it isn't indexed.  Also, the query starts with V(), which is all vertices in the graph but this doesn't result in all vertices being returned but instead adds them to the pipeline interator.  

That being said, there are lots of improvements that can be made to improve query performance.  This would include, changes to the database model so that we knew the propery names ahead of time so that we could use an index instead of a filter.  Also, one optimization that I was going to add which didn't make it in was to use the type if it was provided so that indexes could be used as mentioned above.  For now, I don't think that we can improve on this.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133332
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133332
-----------------------------------------------------------




catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java (line 37)
<https://reviews.apache.org/r/47382/#comment197641>

    If I understood this correctly, the basepipe for the Gremlin search for entities begins by trying to identify all entity vertices (by virtue of using the full text search property that is common to all vertices). This would still be a huge result set to begin with, no?


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java, line 38
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383415#file1383415line38>
> >
> >     This comment is present in DefaultDateFormatter() as well. Consider removing from here.

ok


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java, line 71
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383418#file1383418line71>
> >
> >     for easier readability, consider replacing all "replacement = propName" with the following block just before the return statement:
> >     
> >       if(replacement == null) {
> >         replacement = propName;
> >       }
> >     
> >       return replacement;

yes, that will make the code cleaner.
I will make the changes.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java, line 80
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383418#file1383418line80>
> >
> >     Would it help to update m_qualifiedToCleanMap with the result? The next lookup would be faster. This would work only if dataType.fieldMapping().fields remains unchanged.
> >     
> >     m_qualifiedToCleanMap.put(propName, replacement);

yeah, I thought about that but it seemed like a premature optimization that would cause issues if the underlying mappings changed as you mentioned.
IMO, there are a lot of other places where we could optimize before this.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java, line 104
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383418#file1383418line104>
> >
> >     Refer to comments for toCleanName() - the same comments apply for toFullyQualifiedName() as well.

agreed


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java, line 129
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383418#file1383418line129>
> >
> >     typo: "mnodified_time" ==> "modified_time"

good catch


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 67
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line67>
> >
> >     Consider adding additional information to the exception - like name/ID of the existing entity, type & name/ID of entity being created. This will be handly in troubleshooting.
> >     
> >     Please review other exceptions raised in this class for similar updates.

Yeah, there are lots of places where the exception msg could be better.  I just didn't have the time to get then all cleaned up.  In this case, when I wrote the exception it was my opinion that because the user know which entity they were creating, and which already exists, that the message would be sufficient.

I will add additional info to the exception msgs in this class.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java, line 41
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383430#file1383430line41>
> >
> >     Consider adding query details in the exception message to help in troubleshooting.

Parsing errors are already provied to the user in this case:
For the invalid query: api/atlas/v1/entities?someProperty~~InvalidOperator~~someValue

The following response is returned:

{
status: "400",
message: "Unable to parse query: Cannot parse 'someProperty~~InvalidOperator~~someValue': Encountered " <FUZZY_SLOP> "~InvalidOperator "" at line 1, column 13. Was expecting one of: <EOF> <AND> ... <OR> ... <NOT> ... "+" ... "-" ... <BAREOPER> ... "(" ... "*" ... "^" ... <QUOTED> ... <TERM> ... <PREFIXTERM> ... <WILDTERM> ... <REGEXPTERM> ... "[" ... "{" ... <NUMBER> ... "
}


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java, line 39
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383415#file1383415line39>
> >
> >     Shouldn't "modified_time" be also registered here?

yes, that makes sense.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java, line 47
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383420#file1383420line47>
> >
> >     Would request have ID-property in all cases? If not, consider adding request.toString() to the exception message. AtlasQuery implementations should return appropriate value from toString().

Yes, the request would fail validation if the id isn't provided so the request will always contain the ID property at this point.
I agree that it would be nice to provide a user friendly toString() implementation to AtlasQuery implementations, unfortunately the toString() provided by GremlinPipeline isn't very user friendly so a bit of work will be required to provide this.  Would it be ok to handle this as a separate follow-up Jira?


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383428#file1383428line37>
> >
> >     Since this method requires ID to be given, consider renaming this to getResourceById().
> >     
> >     Also consider if making the return type to "SingleResult" (a new class) would make it easier to read/understand. "Result" deals with a Collection of propertyMaps.

ok, I will rename the method.
Yes, it would probably be cleaner to return a result specific to single results.
Due to time considerations, this patch is being offered for review in a state that isn't consistent with my normal standards for a patch being posted for review.  So, there are many refactorings and other cleanup that I would like to do but just didn't/don't have the time.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133355
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Madhan Neethiraj <ma...@apache.org>.

> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java, line 80
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383418#file1383418line80>
> >
> >     Would it help to update m_qualifiedToCleanMap with the result? The next lookup would be faster. This would work only if dataType.fieldMapping().fields remains unchanged.
> >     
> >     m_qualifiedToCleanMap.put(propName, replacement);
> 
> John Speidel wrote:
>     yeah, I thought about that but it seemed like a premature optimization that would cause issues if the underlying mappings changed as you mentioned.
>     IMO, there are a lot of other places where we could optimize before this.

ok, thanks. We can revisit this in a later patch.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java, line 47
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383420#file1383420line47>
> >
> >     Would request have ID-property in all cases? If not, consider adding request.toString() to the exception message. AtlasQuery implementations should return appropriate value from toString().
> 
> John Speidel wrote:
>     Yes, the request would fail validation if the id isn't provided so the request will always contain the ID property at this point.
>     I agree that it would be nice to provide a user friendly toString() implementation to AtlasQuery implementations, unfortunately the toString() provided by GremlinPipeline isn't very user friendly so a bit of work will be required to provide this.  Would it be ok to handle this as a separate follow-up Jira?

Yes. Review/update of the exception message text can be handled in a separate JIRA.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383428#file1383428line37>
> >
> >     Since this method requires ID to be given, consider renaming this to getResourceById().
> >     
> >     Also consider if making the return type to "SingleResult" (a new class) would make it easier to read/understand. "Result" deals with a Collection of propertyMaps.
> 
> John Speidel wrote:
>     ok, I will rename the method.
>     Yes, it would probably be cleaner to return a result specific to single results.
>     Due to time considerations, this patch is being offered for review in a state that isn't consistent with my normal standards for a patch being posted for review.  So, there are many refactorings and other cleanup that I would like to do but just didn't/don't have the time.

ok. Method renaming is good for this patch. Lets review on using a different return type for getResourceById() in a separate JIRA.


> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java, line 41
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383430#file1383430line41>
> >
> >     Consider adding query details in the exception message to help in troubleshooting.
> 
> John Speidel wrote:
>     Parsing errors are already provied to the user in this case:
>     For the invalid query: api/atlas/v1/entities?someProperty~~InvalidOperator~~someValue
>     
>     The following response is returned:
>     
>     {
>     status: "400",
>     message: "Unable to parse query: Cannot parse 'someProperty~~InvalidOperator~~someValue': Encountered " <FUZZY_SLOP> "~InvalidOperator "" at line 1, column 13. Was expecting one of: <EOF> <AND> ... <OR> ... <NOT> ... "+" ... "-" ... <BAREOPER> ... "(" ... "*" ... "^" ... <QUOTED> ... <TERM> ... <PREFIXTERM> ... <WILDTERM> ... <REGEXPTERM> ... "[" ... "{" ... <NUMBER> ... "
>     }

ok. These details look good for troubleshooting. No changes are needed. Thanks.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133355
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133355
-----------------------------------------------------------



John - here are my review comments so far. I will complete rest of the review tomorrow.


catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java (line 38)
<https://reviews.apache.org/r/47382/#comment197677>

    This comment is present in DefaultDateFormatter() as well. Consider removing from here.



catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java (line 39)
<https://reviews.apache.org/r/47382/#comment197678>

    Shouldn't "modified_time" be also registered here?



catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java (line 71)
<https://reviews.apache.org/r/47382/#comment197671>

    for easier readability, consider replacing all "replacement = propName" with the following block just before the return statement:
    
      if(replacement == null) {
        replacement = propName;
      }
    
      return replacement;



catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java (line 80)
<https://reviews.apache.org/r/47382/#comment197674>

    Would it help to update m_qualifiedToCleanMap with the result? The next lookup would be faster. This would work only if dataType.fieldMapping().fields remains unchanged.
    
    m_qualifiedToCleanMap.put(propName, replacement);



catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java (line 104)
<https://reviews.apache.org/r/47382/#comment197675>

    Refer to comments for toCleanName() - the same comments apply for toFullyQualifiedName() as well.



catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java (line 129)
<https://reviews.apache.org/r/47382/#comment197672>

    typo: "mnodified_time" ==> "modified_time"



catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 67)
<https://reviews.apache.org/r/47382/#comment197736>

    Consider adding additional information to the exception - like name/ID of the existing entity, type & name/ID of entity being created. This will be handly in troubleshooting.
    
    Please review other exceptions raised in this class for similar updates.



catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java (line 47)
<https://reviews.apache.org/r/47382/#comment197745>

    Would request have ID-property in all cases? If not, consider adding request.toString() to the exception message. AtlasQuery implementations should return appropriate value from toString().



catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java (line 37)
<https://reviews.apache.org/r/47382/#comment197757>

    Since this method requires ID to be given, consider renaming this to getResourceById().
    
    Also consider if making the return type to "SingleResult" (a new class) would make it easier to read/understand. "Result" deals with a Collection of propertyMaps.



catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java (line 41)
<https://reviews.apache.org/r/47382/#comment197751>

    Consider adding query details in the exception message to help in troubleshooting.


- Madhan Neethiraj


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 2:27 p.m., Hemanth Yamijala wrote:
> >

Good catch Hemanth.
This property is supposed to default to 'true' but at some point during cleanup/refactoring I broke this and didn't catch it because all of my functional tests set this value and there is no unit test for this.
I will chage the default back to true and add a unit test to assert this.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133357
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133357
-----------------------------------------------------------




catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java (line 73)
<https://reviews.apache.org/r/47382/#comment197676>

    The default value of available_as_tag is false. When I started testing this, I ran into these errors. Also, there's no PUT API on terms to modify this value. Is this by design? If yes, we should be very careful to create a term with this tag set to true.


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 57
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57>
> >
> >     This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.
> 
> John Speidel wrote:
>     ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input.

John, we do one time model registration of other models like Hive, Sqoop, Storm etc. These are done one time when the (active) server starts up. The method was introduced in ATLAS-512. Broadly it involves generating a model definition and writing it out as a json file as part of the build process. This is then packaged under the models directory and is picked up automatically by the server at start up. If you could go through the patch in ATLAS-512 and follow the same steps we should be good for fixing this.


- Hemanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 57
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57>
> >
> >     This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.
> 
> John Speidel wrote:
>     ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input.
> 
> Hemanth Yamijala wrote:
>     John, we do one time model registration of other models like Hive, Sqoop, Storm etc. These are done one time when the (active) server starts up. The method was introduced in ATLAS-512. Broadly it involves generating a model definition and writing it out as a json file as part of the build process. This is then packaged under the models directory and is picked up automatically by the server at start up. If you could go through the patch in ATLAS-512 and follow the same steps we should be good for fixing this.

I would prefer to handle this in another patch if that is ok with you.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 57
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57>
> >
> >     This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.
> 
> John Speidel wrote:
>     ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input.
> 
> Hemanth Yamijala wrote:
>     John, we do one time model registration of other models like Hive, Sqoop, Storm etc. These are done one time when the (active) server starts up. The method was introduced in ATLAS-512. Broadly it involves generating a model definition and writing it out as a json file as part of the build process. This is then packaged under the models directory and is picked up automatically by the server at start up. If you could go through the patch in ATLAS-512 and follow the same steps we should be good for fixing this.
> 
> John Speidel wrote:
>     I would prefer to handle this in another patch if that is ok with you.
> 
> Hemanth Yamijala wrote:
>     Yes, this is fine. Will file a JIRA to track this.

Being tracked by: https://issues.apache.org/jira/browse/ATLAS-805


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------


On May 17, 2016, 10:41 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:41 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   distro/src/conf/policy-store.txt b072b49 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
>   webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 57
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57>
> >
> >     This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.

ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 57
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57>
> >
> >     This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.
> 
> John Speidel wrote:
>     ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input.
> 
> Hemanth Yamijala wrote:
>     John, we do one time model registration of other models like Hive, Sqoop, Storm etc. These are done one time when the (active) server starts up. The method was introduced in ATLAS-512. Broadly it involves generating a model definition and writing it out as a json file as part of the build process. This is then packaged under the models directory and is picked up automatically by the server at start up. If you could go through the patch in ATLAS-512 and follow the same steps we should be good for fixing this.
> 
> John Speidel wrote:
>     I would prefer to handle this in another patch if that is ok with you.
> 
> Hemanth Yamijala wrote:
>     Yes, this is fine. Will file a JIRA to track this.
> 
> John Speidel wrote:
>     Being tracked by: https://issues.apache.org/jira/browse/ATLAS-805

Above jira is not the correct one for this issue.
Correct Jira is: https://issues.apache.org/jira/browse/ATLAS-806


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------


On May 17, 2016, 10:41 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:41 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   distro/src/conf/policy-store.txt b072b49 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
>   webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line 57
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383419#file1383419line57>
> >
> >     This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.
> 
> John Speidel wrote:
>     ok, I will investigate this but I didn't see a way to do this without making changes to Atlas proper, which was a desing goal based on team input.
> 
> Hemanth Yamijala wrote:
>     John, we do one time model registration of other models like Hive, Sqoop, Storm etc. These are done one time when the (active) server starts up. The method was introduced in ATLAS-512. Broadly it involves generating a model definition and writing it out as a json file as part of the build process. This is then packaged under the models directory and is picked up automatically by the server at start up. If you could go through the patch in ATLAS-512 and follow the same steps we should be good for fixing this.
> 
> John Speidel wrote:
>     I would prefer to handle this in another patch if that is ok with you.

Yes, this is fine. Will file a JIRA to track this.


- Hemanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------


On May 17, 2016, 10:41 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:41 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   distro/src/conf/policy-store.txt b072b49 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
>   webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133328
-----------------------------------------------------------




catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 57)
<https://reviews.apache.org/r/47382/#comment197635>

    This would be a problem if multiple threads are trying to define the type at the same time (as could happen if multiple clients are trying to create taxonomies / terms at the same time). We should move type registration to a one time activity as the rest of the framework.


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 4:53 a.m., Hemanth Yamijala wrote:
> >

Actually this change shouldn't have been included in the patch.
It was from an old local commit to fix the error message.
I will revert back to the old msg.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133323
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133323
-----------------------------------------------------------




typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java (line 64)
<https://reviews.apache.org/r/47382/#comment197632>

    If possible, can we retain the behaviour as before and encapsulate this in a catch block for the exception?


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 6:31 a.m., Hemanth Yamijala wrote:
> >

"id" is the "clean" form for the underlying "__guid" property.  
The mapping between clean and fully qualified property names is handled by the PropertyMapper implementation.
The user only deals with the clean name which is then translated to the fully qualified name which is used in the back end operations.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133330
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133330
-----------------------------------------------------------




catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java (line 78)
<https://reviews.apache.org/r/47382/#comment197639>

    What is the property "id"? There's a property called "__guid" that we generally add to uniquely identify a vertex in the Titan graph. Not sure what this means and how this is assigned?


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 6:41 a.m., Hemanth Yamijala wrote:
> >

ok, I will use the other constructor along with calling of the necessary setters.
But to be honest, why this constructor should be marked this way makes absolutely no sense to me.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133331
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.

> On May 16, 2016, 6:41 a.m., Hemanth Yamijala wrote:
> >
> 
> John Speidel wrote:
>     ok, I will use the other constructor along with calling of the necessary setters.
>     But to be honest, why this constructor should be marked this way makes absolutely no sense to me.

I agree and we could just remove the annotation I think, if the usage seems harmless.


- Hemanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133331
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133331
-----------------------------------------------------------




catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 91)
<https://reviews.apache.org/r/47382/#comment197640>

    This API is marked AudiencePrivate. Not sure why - others who are more familiar with the system can answer. But IMO, we should either use the public .set APIs which seem open for usage, or remove the annotation.


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133702
-----------------------------------------------------------


Ship it!




My comments which we agreed to address in this patch are in. Testing seems to go fine as well. We need to raise follow-up JIRAs for other items which I will do. One weird issue I am seeing is that quick_start is throwing an exception if taxonomy and term are added and queried, before running quickstart. However, Hive hook and import continue to work fine even in that scenario. Will try to get some more data on this ASAP.

- Hemanth Yamijala


On May 17, 2016, 10:41 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:41 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   distro/src/conf/policy-store.txt b072b49 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
>   webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/
-----------------------------------------------------------

(Updated May 17, 2016, 10:41 p.m.)


Review request for atlas and Hemanth Yamijala.


Changes
-------

patch which addresses all issues unless otherwise noted


Bugs: ATLAS-491
    https://issues.apache.org/jira/browse/ATLAS-491


Repository: atlas


Description
-------

Initial implementation of Catalog API.

Known Issues/Limitations:
- No update/delete support for taxonomies/terms
  -- this will be added next week
- Some gaps in test coverage
  - Need more in-depth test coverage that exercise the generated gremlin pipeline
- some refactoring should still be done espcecially in the 'query' package
- need to add more logging
- need to finish some javadoc


Diffs (updated)
-----

  catalog/pom.xml PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
  catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
  catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
  distro/src/conf/policy-store.txt b072b49 
  pom.xml 5e2871e 
  repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
  server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
  webapp/pom.xml de48c15 
  webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
  webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
  webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/47382/diff/


Testing
-------

Ran all existing unit tests and added new tests.


Thanks,

John Speidel

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.

> On May 16, 2016, 7:50 a.m., Hemanth Yamijala wrote:
> > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383499#file1383499line37>
> >
> >     When would the UI flows use this service as opposed to the original entity service? Are all methods here required?
> 
> John Speidel wrote:
>     All of these methods are needed IMO.
>     I don't know when the UI will use DSL queries vs these new queries.
>     The service handles all of the requirements for querying entities for tags as well as tagging entities, which the current DSL doesn't.
>     So, if the UI needs to make a query that is handled by the currentl DSL, then they can use a DSL query could be used.
>     The service doesn't handle creation or modification of entities as this wasn't in scope.

I checked with the folks working on the UI and from the discussion with them, it looks like the current UI flow is going to lookup entities through the current search mechanism (i.e. DSL) and the ability to add business terms to the returned result set. I was told that no new UI flow (including no new search mechanism from the UI) is being planned right now from their perspective. I believe this is a right step in the short term. We should leave the search method to be the existing search method in Atlas and then provide ways to add business terms to the result set. I fully acknowledge this is neither ideal nor as functional as it can be, but maybe we can be a little iterative about this.


- Hemanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133337
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 7:50 a.m., Hemanth Yamijala wrote:
> > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, line 37
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383499#file1383499line37>
> >
> >     When would the UI flows use this service as opposed to the original entity service? Are all methods here required?

All of these methods are needed IMO.
I don't know when the UI will use DSL queries vs these new queries.
The service handles all of the requirements for querying entities for tags as well as tagging entities, which the current DSL doesn't.
So, if the UI needs to make a query that is handled by the currentl DSL, then they can use a DSL query could be used.
The service doesn't handle creation or modification of entities as this wasn't in scope.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133337
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133337
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java (line 37)
<https://reviews.apache.org/r/47382/#comment197652>

    When would the UI flows use this service as opposed to the original entity service? Are all methods here required?


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 4:09 a.m., Hemanth Yamijala wrote:
> >

Yes, I was originally using this but no longer need to access this method.
I will revert to private.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133322
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 4:09 a.m., Hemanth Yamijala wrote:
> >
> 
> John Speidel wrote:
>     Yes, I was originally using this but no longer need to access this method.
>     I will revert to private.

oops, this comment was for the first issue regarding the scope of GraphHelper.findVertex()


> On May 16, 2016, 4:09 a.m., Hemanth Yamijala wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java, line 143
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383490#file1383490line143>
> >
> >     I don't see any access requirements for this method that requires it to be public. Can we please revert this back to the original access level?

yes, will revert.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133322
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133322
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 143)
<https://reviews.apache.org/r/47382/#comment197631>

    I don't see any access requirements for this method that requires it to be public. Can we please revert this back to the original access level?


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 8:04 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, line 116
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383421#file1383421line116>
> >
> >     Both these TODOs are kind of important, and we need to probably file follow-up JIRAs to address these.

ok, I will create follow-up Jira's for these.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133339
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by John Speidel <js...@hortonworks.com>.

> On May 16, 2016, 8:04 a.m., Hemanth Yamijala wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, line 116
> > <https://reviews.apache.org/r/47382/diff/1/?file=1383421#file1383421line116>
> >
> >     Both these TODOs are kind of important, and we need to probably file follow-up JIRAs to address these.
> 
> John Speidel wrote:
>     ok, I will create follow-up Jira's for these.

https://issues.apache.org/jira/browse/ATLAS-808


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133339
-----------------------------------------------------------


On May 17, 2016, 10:41 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:41 p.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   distro/src/conf/policy-store.txt b072b49 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java 211ee7f 
>   webapp/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 8ce3f4c 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
>   webapp/src/test/java/org/apache/atlas/authorize/AtlasAuthorizationUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 47382: ATLAS-491 : Business Catalog API

Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133339
-----------------------------------------------------------




catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java (line 116)
<https://reviews.apache.org/r/47382/#comment197654>

    Both these TODOs are kind of important, and we need to probably file follow-up JIRAs to address these.


- Hemanth Yamijala


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION 
>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>