You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/11 11:22:49 UTC
Review Request 69720: Made `SSLTest` an unparameterized test suite.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-5189
https://issues.apache.org/jira/browse/MESOS-5189
Repository: mesos
Description
-------
This general and reusable testing class is made unparameterized since
deriving from a parameterized test is cumbersome (e.g., requires manual
disambiguation of possibly private types and methods inherited from the
respective `::testing::WithParamInterface` base class).
This test makes `SSLTest` an unparameterized test suite which eases
reuse. We are able to remove a number of redundant test
parameterizations along the way.
Diffs
-----
3rdparty/libprocess/include/process/ssl/gtest.hpp 23d7aee963b6fb489403a94500d39e3413c7fcdd
3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
Diff: https://reviews.apache.org/r/69720/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69720: Made `SSLTest` an unparameterized test
suite.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/#review212037
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 14, 2019, 7:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69720/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 7:54 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This general and reusable testing class is made unparameterized since
> deriving from a parameterized test is cumbersome (e.g., requires manual
> disambiguation of possibly private types and methods inherited from the
> respective `::testing::WithParamInterface` base class).
>
> This patch makes `SSLTest` an unparameterized test suite which eases
> reuse. We are able to remove a number of redundant test
> parameterizations along the way.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/gtest.hpp 23d7aee963b6fb489403a94500d39e3413c7fcdd
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69720/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69720: Made `SSLTest` an unparameterized test
suite.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/
-----------------------------------------------------------
(Updated Jan. 14, 2019, 8:54 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Addressed Joseph's comments.
Bugs: MESOS-5189
https://issues.apache.org/jira/browse/MESOS-5189
Repository: mesos
Description
-------
This general and reusable testing class is made unparameterized since
deriving from a parameterized test is cumbersome (e.g., requires manual
disambiguation of possibly private types and methods inherited from the
respective `::testing::WithParamInterface` base class).
This patch makes `SSLTest` an unparameterized test suite which eases
reuse. We are able to remove a number of redundant test
parameterizations along the way.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/gtest.hpp 23d7aee963b6fb489403a94500d39e3413c7fcdd
3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
Diff: https://reviews.apache.org/r/69720/diff/2/
Changes: https://reviews.apache.org/r/69720/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69720: Made `SSLTest` an unparameterized test
suite.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 14, 2019, 7:40 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp
> > Line 417 (original), 421 (patched)
> > <https://reviews.apache.org/r/69720/diff/1/?file=2119199#file2119199line421>
> >
> > You can consider moving this test up to group with the other parameterized tests. (Or moving those tests down)
Some reordering here, follow-up reordering in https://reviews.apache.org/r/69721/.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/#review211957
-----------------------------------------------------------
On Jan. 14, 2019, 8:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69720/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2019, 8:54 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This general and reusable testing class is made unparameterized since
> deriving from a parameterized test is cumbersome (e.g., requires manual
> disambiguation of possibly private types and methods inherited from the
> respective `::testing::WithParamInterface` base class).
>
> This patch makes `SSLTest` an unparameterized test suite which eases
> reuse. We are able to remove a number of redundant test
> parameterizations along the way.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/gtest.hpp 23d7aee963b6fb489403a94500d39e3413c7fcdd
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69720/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69720: Made `SSLTest` an unparameterized test
suite.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/#review211957
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/tests/ssl_tests.cpp
Line 237 (original), 241 (patched)
<https://reviews.apache.org/r/69720/#comment297536>
This test doesn't need the parameterization. It can use the base class.
3rdparty/libprocess/src/tests/ssl_tests.cpp
Line 266 (original), 270 (patched)
<https://reviews.apache.org/r/69720/#comment297537>
This one also doesn't need parameters.
3rdparty/libprocess/src/tests/ssl_tests.cpp
Line 417 (original), 421 (patched)
<https://reviews.apache.org/r/69720/#comment297538>
You can consider moving this test up to group with the other parameterized tests. (Or moving those tests down)
- Joseph Wu
On Jan. 11, 2019, 3:22 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69720/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 3:22 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5189
> https://issues.apache.org/jira/browse/MESOS-5189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This general and reusable testing class is made unparameterized since
> deriving from a parameterized test is cumbersome (e.g., requires manual
> disambiguation of possibly private types and methods inherited from the
> respective `::testing::WithParamInterface` base class).
>
> This patch makes `SSLTest` an unparameterized test suite which eases
> reuse. We are able to remove a number of redundant test
> parameterizations along the way.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/gtest.hpp 23d7aee963b6fb489403a94500d39e3413c7fcdd
> 3rdparty/libprocess/src/tests/ssl_tests.cpp bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
>
>
> Diff: https://reviews.apache.org/r/69720/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>