[GitHub] [couchdb-fauxton] garrensmith commented on a change in pull request #1208: Added total document count to footer matching total database count format

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #1208: Added total document count to footer matching total database count format
URL: https://github.com/apache/couchdb-fauxton/pull/1208#discussion_r303191377
 
 

 ##########
 File path: app/addons/documents/index-results/components/pagination/PaginationFooter.js
 ##########
 @@ -10,50 +10,70 @@
 // License for the specific language governing permissions and limitations under
 // the License.
 
-import React from 'react';
-import PagingControls from './PagingControls.js';
-import PerPageSelector from './PerPageSelector.js';
-import TableControls from './TableControls';
+import React from "react";
+import PagingControls from "./PagingControls.js";
+import PerPageSelector from "./PerPageSelector.js";
+import TableControls from "./TableControls";
 
 export default class PaginationFooter extends React.Component {
   constructor(props) {
     super(props);
   }
 
-  getPageNumberText () {
+  getPageNumberText() {
     const { docs, pageStart, pageEnd } = this.props;
 
     if (docs.length === 0) {
       return <span>Showing 0 documents.</span>;
     }
 
-    return <span>Showing document {pageStart} - {pageEnd}.</span>;
+    return (
+      <span>
+        Showing document {pageStart} - {pageEnd} of {docs.length} documents.
 
 Review comment:
   THere are issues in this project  you can look at. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services