You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/04/13 23:32:24 UTC
Review Request 46167: Replace org.apache.aurora.common.base.Closure
with java.util.function.Consumer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46167/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Maxim Khutornenko.
Repository: aurora
Description
-------
Commons came with a `Closure` type which is identical to the Java 8 type `Consumer`. This replaces the former with the latter in the interests of reducing the commons code and fork.
Diffs
-----
commons/src/main/java/org/apache/aurora/common/base/Closure.java 42c9d11974f0d0aa4408404b1ed67ee202fc1742
commons/src/main/java/org/apache/aurora/common/base/Closures.java 0953119ced73eefa897351c59e767bb7e52fcbdd
commons/src/main/java/org/apache/aurora/common/util/StateMachine.java e8aa00054799b4d06aacc41b857b98527bf02720
commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java bcfa003b2220e6dd53aee7306e068a4e619877c4
commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 07bf23c99e1624ef98beaac5763549db28d78c69
commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java 9591e824354b6d98811aa3ca0e99cb24258881ae
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java debe89934f424a3dfc151cd489acfc280d074a59
src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java 302388d78c833a394cfab84342028da9d26660ad
src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6fd29512ace01f98024fd3b6db00e6c903ea8b89
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 5143668c8dacb2d8695cf8299abf2e6fab536de2
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 76a574fd4fb18e0afd8da6387286b72cc583b7fd
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 766ec2d51ac875ce263d7e4ad8827424555b5b5e
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6
Diff: https://reviews.apache.org/r/46167/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 46167: Replace
org.apache.aurora.common.base.Closure with java.util.function.Consumer
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46167/#review128762
-----------------------------------------------------------
Ship it!
Master (ea76487) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 13, 2016, 9:32 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46167/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 9:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Commons came with a `Closure` type which is identical to the Java 8 type `Consumer`. This replaces the former with the latter in the interests of reducing the commons code and fork.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/base/Closure.java 42c9d11974f0d0aa4408404b1ed67ee202fc1742
> commons/src/main/java/org/apache/aurora/common/base/Closures.java 0953119ced73eefa897351c59e767bb7e52fcbdd
> commons/src/main/java/org/apache/aurora/common/util/StateMachine.java e8aa00054799b4d06aacc41b857b98527bf02720
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java bcfa003b2220e6dd53aee7306e068a4e619877c4
> commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 07bf23c99e1624ef98beaac5763549db28d78c69
> commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java 9591e824354b6d98811aa3ca0e99cb24258881ae
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java debe89934f424a3dfc151cd489acfc280d074a59
> src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java 302388d78c833a394cfab84342028da9d26660ad
> src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6fd29512ace01f98024fd3b6db00e6c903ea8b89
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 5143668c8dacb2d8695cf8299abf2e6fab536de2
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 76a574fd4fb18e0afd8da6387286b72cc583b7fd
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 766ec2d51ac875ce263d7e4ad8827424555b5b5e
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6
>
> Diff: https://reviews.apache.org/r/46167/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46167: Replace
org.apache.aurora.common.base.Closure with java.util.function.Consumer
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46167/#review129189
-----------------------------------------------------------
Master (02ffef5) is red with this patch.
./build-support/jenkins/build.sh
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7f3fba2f6938>(['./pants', '--pants-distdir=/tmp/user/10021/tmpowzb6d', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7f3fba2f6938> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 631 passed, 6 skipped, 1 warnings, 8 error in 216.74 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
21:29:16 05:26 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 15, 2016, 9:02 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46167/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 9:02 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Commons came with a `Closure` type which is identical to the Java 8 type `Consumer`. This replaces the former with the latter in the interests of reducing the commons code and fork.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/base/Closure.java 42c9d11974f0d0aa4408404b1ed67ee202fc1742
> commons/src/main/java/org/apache/aurora/common/base/Closures.java 0953119ced73eefa897351c59e767bb7e52fcbdd
> commons/src/main/java/org/apache/aurora/common/base/Consumers.java PRE-CREATION
> commons/src/main/java/org/apache/aurora/common/util/StateMachine.java e8aa00054799b4d06aacc41b857b98527bf02720
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java bcfa003b2220e6dd53aee7306e068a4e619877c4
> commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 07bf23c99e1624ef98beaac5763549db28d78c69
> commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java 9591e824354b6d98811aa3ca0e99cb24258881ae
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java debe89934f424a3dfc151cd489acfc280d074a59
> src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java 302388d78c833a394cfab84342028da9d26660ad
> src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6fd29512ace01f98024fd3b6db00e6c903ea8b89
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 5143668c8dacb2d8695cf8299abf2e6fab536de2
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 76a574fd4fb18e0afd8da6387286b72cc583b7fd
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 766ec2d51ac875ce263d7e4ad8827424555b5b5e
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6
>
> Diff: https://reviews.apache.org/r/46167/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46167: Replace
org.apache.aurora.common.base.Closure with java.util.function.Consumer
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46167/
-----------------------------------------------------------
(Updated April 15, 2016, 2:02 p.m.)
Review request for Aurora, John Sirois and Maxim Khutornenko.
Changes
-------
Feedback.
Repository: aurora
Description
-------
Commons came with a `Closure` type which is identical to the Java 8 type `Consumer`. This replaces the former with the latter in the interests of reducing the commons code and fork.
Diffs (updated)
-----
commons/src/main/java/org/apache/aurora/common/base/Closure.java 42c9d11974f0d0aa4408404b1ed67ee202fc1742
commons/src/main/java/org/apache/aurora/common/base/Closures.java 0953119ced73eefa897351c59e767bb7e52fcbdd
commons/src/main/java/org/apache/aurora/common/base/Consumers.java PRE-CREATION
commons/src/main/java/org/apache/aurora/common/util/StateMachine.java e8aa00054799b4d06aacc41b857b98527bf02720
commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java bcfa003b2220e6dd53aee7306e068a4e619877c4
commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 07bf23c99e1624ef98beaac5763549db28d78c69
commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java 9591e824354b6d98811aa3ca0e99cb24258881ae
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java debe89934f424a3dfc151cd489acfc280d074a59
src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java 302388d78c833a394cfab84342028da9d26660ad
src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6fd29512ace01f98024fd3b6db00e6c903ea8b89
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 5143668c8dacb2d8695cf8299abf2e6fab536de2
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 76a574fd4fb18e0afd8da6387286b72cc583b7fd
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 766ec2d51ac875ce263d7e4ad8827424555b5b5e
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6
Diff: https://reviews.apache.org/r/46167/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 46167: Replace
org.apache.aurora.common.base.Closure with java.util.function.Consumer
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46167/#review128766
-----------------------------------------------------------
Ship it!
commons/src/main/java/org/apache/aurora/common/base/Closures.java (line 68)
<https://reviews.apache.org/r/46167/#comment192229>
s/closer/consumer here and in comments.
- Maxim Khutornenko
On April 13, 2016, 9:32 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46167/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 9:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Commons came with a `Closure` type which is identical to the Java 8 type `Consumer`. This replaces the former with the latter in the interests of reducing the commons code and fork.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/base/Closure.java 42c9d11974f0d0aa4408404b1ed67ee202fc1742
> commons/src/main/java/org/apache/aurora/common/base/Closures.java 0953119ced73eefa897351c59e767bb7e52fcbdd
> commons/src/main/java/org/apache/aurora/common/util/StateMachine.java e8aa00054799b4d06aacc41b857b98527bf02720
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java bcfa003b2220e6dd53aee7306e068a4e619877c4
> commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 07bf23c99e1624ef98beaac5763549db28d78c69
> commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java 9591e824354b6d98811aa3ca0e99cb24258881ae
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java debe89934f424a3dfc151cd489acfc280d074a59
> src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java 302388d78c833a394cfab84342028da9d26660ad
> src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6fd29512ace01f98024fd3b6db00e6c903ea8b89
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 5143668c8dacb2d8695cf8299abf2e6fab536de2
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 76a574fd4fb18e0afd8da6387286b72cc583b7fd
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 766ec2d51ac875ce263d7e4ad8827424555b5b5e
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6
>
> Diff: https://reviews.apache.org/r/46167/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46167: Replace
org.apache.aurora.common.base.Closure with java.util.function.Consumer
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46167/#review128765
-----------------------------------------------------------
Ship it!
commons/src/main/java/org/apache/aurora/common/base/Closures.java (lines 49 - 50)
<https://reviews.apache.org/r/46167/#comment192228>
s/closure/consumer/ ?
- John Sirois
On April 13, 2016, 3:32 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46167/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 3:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Commons came with a `Closure` type which is identical to the Java 8 type `Consumer`. This replaces the former with the latter in the interests of reducing the commons code and fork.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/base/Closure.java 42c9d11974f0d0aa4408404b1ed67ee202fc1742
> commons/src/main/java/org/apache/aurora/common/base/Closures.java 0953119ced73eefa897351c59e767bb7e52fcbdd
> commons/src/main/java/org/apache/aurora/common/util/StateMachine.java e8aa00054799b4d06aacc41b857b98527bf02720
> commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java bcfa003b2220e6dd53aee7306e068a4e619877c4
> commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java 07bf23c99e1624ef98beaac5763549db28d78c69
> commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java 9591e824354b6d98811aa3ca0e99cb24258881ae
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java debe89934f424a3dfc151cd489acfc280d074a59
> src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java 302388d78c833a394cfab84342028da9d26660ad
> src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6fd29512ace01f98024fd3b6db00e6c903ea8b89
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 5143668c8dacb2d8695cf8299abf2e6fab536de2
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 76a574fd4fb18e0afd8da6387286b72cc583b7fd
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 766ec2d51ac875ce263d7e4ad8827424555b5b5e
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0256c06ee0794bf50bccaa283c5086da7642f3f6
>
> Diff: https://reviews.apache.org/r/46167/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>