You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (JIRA)" <ji...@apache.org> on 2016/06/21 22:06:58 UTC

[jira] [Commented] (SPARK-16120) getCurrentLogFiles method in ReceiverSuite "WAL - generating and cleaning" case uses external variable instead of the passed parameter

    [ https://issues.apache.org/jira/browse/SPARK-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342852#comment-15342852 ] 

Apache Spark commented on SPARK-16120:
--------------------------------------

User 'ahmed-mahran' has created a pull request for this issue:
https://github.com/apache/spark/pull/13825

> getCurrentLogFiles method in ReceiverSuite "WAL - generating and cleaning" case uses external variable instead of the passed parameter
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-16120
>                 URL: https://issues.apache.org/jira/browse/SPARK-16120
>             Project: Spark
>          Issue Type: Test
>          Components: Streaming, Tests
>            Reporter: Ahmed Mahran
>            Priority: Trivial
>              Labels: easyfix, newbie, test
>
> In ReceiverSuite.scala, in the test case "write ahead log - generating and cleaning", the inner method getCurrentLogFiles uses external variable logDirectory1 instead of the passed parameter logDirectory
> {code}
> def getCurrentLogFiles(logDirectory: File): Seq[String] = {
>   try {
>     if (logDirectory.exists()) {
>       logDirectory1.listFiles().filter { _.getName.startsWith("log") }.map { _.toString }
>     } else {
>       Seq.empty
>     }
>   } catch {
>     case e: Exception =>
>       Seq.empty
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org