[GitHub] [hive] ayushtkn commented on a diff in pull request #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #3491:
URL: https://github.com/apache/hive/pull/3491#discussion_r936247615


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java:
##########
@@ -201,6 +201,8 @@ private HiveConf initializeConf() {
 
     // Tez configuration
     hiveConf.setBoolean("tez.local.mode", true);
+    // TODO: enable below option once HIVE-26445 is investigated
+    // hiveConf.setBoolean("tez.local.mode.without.network", true);

Review Comment:
   Not sure but it says in the description:
   ```
   which is in the same JVM as the client.
   ```
   May be some instance is getting shared by the client and one change is impacting other, hence the NPE which is mentioned in HIVE-26445.
   
   I share the same doubt as @zabetak , we should atleast figure out the reason for failure if it is nothing core-related this property, then this should be ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org