[GitHub] marcoabreu commented on a change in pull request #13940: Add back R tests and fix typo around R and perl tests

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #13940: Add back R tests and fix typo around R and perl tests
URL: https://github.com/apache/incubator-mxnet/pull/13940#discussion_r249302954
 
 

 ##########
 File path: Makefile
 ##########
 @@ -596,7 +596,7 @@ rpkg:
 	cp -rf 3rdparty/dmlc-core/include/* R-package/inst/include/
 	cp -rf 3rdparty/tvm/nnvm/include/* R-package/inst/include
 	Rscript -e "if(!require(devtools)){install.packages('devtools', repo = 'https://cloud.r-project.org/')}"
-	Rscript -e "if(!require(devtools)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}"
+	Rscript -e "if(!require(roxygen2)||packageVersion('roxygen2') < '6.1.1'){install.packages('roxygen2', repo = 'https://cloud.r-project.org/')}"
 
 Review comment:
   @jeremiedb could you double-check this please? You recently added this line and I assumed that it was a copy&paste leftover.
   
   The result was that the script tried to query for the version of roxygen2 even if it was not installed, thus leading to a "null pointer exception".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services