You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/16 03:28:06 UTC

[GitHub] [flink] wuchong commented on a change in pull request #9120: [FLINK-13216][FLINK-13153][table-planner-blink] Fix Max_Retract and Min_Retract may produce incorrect result

wuchong commented on a change in pull request #9120: [FLINK-13216][FLINK-13153][table-planner-blink] Fix Max_Retract and Min_Retract may produce incorrect result
URL: https://github.com/apache/flink/pull/9120#discussion_r303715390
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/MaxWithRetractAggFunction.java
 ##########
 @@ -135,6 +135,8 @@ private void updateMax(MaxWithRetractAccumulator<T> acc) throws Exception {
 		// when both of them are expired.
 
 Review comment:
   Yes. This is the problem. We should set max to null when the map is empty.
   
   The "expired" means the content of MapView might be cleared because of state ttl.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services