[jira] [Work logged] (IMAGING-238) Return copied byte arrays in Png Chunk and Png Chunk ICCP

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMAGING-238?focusedWorklogId=341032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341032 ]

ASF GitHub Bot logged work on IMAGING-238:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Nov/19 08:46
            Start Date: 10/Nov/19 08:46
    Worklog Time Spent: 10m 
      Work Description: kinow commented on pull request #56: IMAGING-238: Return copied byte arrays in PNG Chunk and ICCP PNG Chunk
URL: https://github.com/apache/commons-imaging/pull/56
 
 
   Returns copied byte arrays, adds javadocs, and also adds a unit test for the ICCP chunk.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 341032)
    Remaining Estimate: 0h
            Time Spent: 10m

> Return copied byte arrays in Png Chunk and Png Chunk ICCP
> ---------------------------------------------------------
>
>                 Key: IMAGING-238
>                 URL: https://issues.apache.org/jira/browse/IMAGING-238
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: PNG
>    Affects Versions: 1.0-alpha1
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 1.0-alpha2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Noticed that the PngChunkIccp class was never tested. While looking at this class, also noticed both this class and its parent had no javadoc, and a few TODO notes.
> We can remove the TODO's by returning copied values (they are already final, and the parser may fail if users change the bytes in the array).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)