You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2014/12/09 23:13:50 UTC

[05/12] trafficserver git commit: TS-3231: remove SIGUSR2 handling from traffic_manager

TS-3231: remove SIGUSR2 handling from traffic_manager

SIGUSR2 causes traffic_manager to log a stack trace using
ink_stack_trace_dump(). However, ink_stack_trace_dump() calls
alarm(3), which will make us exit with SIGALRM.


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/d7a55830
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/d7a55830
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/d7a55830

Branch: refs/heads/master
Commit: d7a55830d1029ef175842dd576645e844deef92a
Parents: b64dfa7
Author: James Peach <jp...@apache.org>
Authored: Mon Nov 17 09:37:56 2014 -0800
Committer: James Peach <jp...@apache.org>
Committed: Tue Dec 9 13:48:11 2014 -0800

----------------------------------------------------------------------
 cmd/traffic_manager/traffic_manager.cc | 10 ----------
 1 file changed, 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d7a55830/cmd/traffic_manager/traffic_manager.cc
----------------------------------------------------------------------
diff --git a/cmd/traffic_manager/traffic_manager.cc b/cmd/traffic_manager/traffic_manager.cc
index 93d62d9..cfcb44d 100644
--- a/cmd/traffic_manager/traffic_manager.cc
+++ b/cmd/traffic_manager/traffic_manager.cc
@@ -94,7 +94,6 @@ static void SignalAlrmHandler(int sig);
 #endif
 
 static volatile int sigHupNotifier = 0;
-static volatile int sigUsr2Notifier = 0;
 static void SigChldHandler(int sig);
 
 static void
@@ -697,11 +696,6 @@ main(int argc, char **argv)
       sigHupNotifier = 0;
       mgmt_log(stderr, "[main] Reading Configuration Files Reread\n");
     }
-    // Check for SIGUSR2
-    if (sigUsr2Notifier != 0) {
-      ink_stack_trace_dump();
-      sigUsr2Notifier = 0;
-    }
 
     lmgmt->ccom->generateClusterDelta();
 
@@ -834,10 +828,6 @@ SignalHandler(int sig)
     return;
   }
 
-  if (sig == SIGUSR2) {
-    sigUsr2Notifier = 1;
-    return;
-  }
   fprintf(stderr, "[TrafficManager] ==> Cleaning up and reissuing signal #%d\n", sig);
   mgmt_elog(stderr, 0, "[TrafficManager] ==> Cleaning up and reissuing signal #%d\n", sig);