You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2008/09/27 19:36:18 UTC

svn commit: r699697 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: remm
Date: Sat Sep 27 10:36:18 2008
New Revision: 699697

URL: http://svn.apache.org/viewvc?rev=699697&view=rev
Log:
- Votes.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=699697&r1=699696&r2=699697&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Sep 27 10:36:18 2008
@@ -186,7 +186,7 @@
 
 * Make the size limit on objects placed in the static resource cache configurable
   http://svn.apache.org/viewvc?rev=699287&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45851
@@ -198,12 +198,13 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
   Check super class for preDestroy and postContruct
   http://people.apache.org/~markt/patches/2008-09-26-bug45285.patch
-  +1: markt
+  +1: markt, remm
   -1:
 
 * Fix serialisation issue reported by Find Bugs
   http://svn.apache.org/viewvc?rev=699633&view=rev
   +1: markt
+   0: remm (StdContext was marked as Serializable for an experiment; obviously it won't work)
   -1:
 
 * Fix small memory leak found by Find Bugs
@@ -213,21 +214,22 @@
 
 * Fix HTML decoding bug found by Find Bugs
   http://svn.apache.org/viewvc?rev=699635&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix ASCII parsing bug found by Find Bugs
   http://svn.apache.org/viewvc?rev=699644&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix casting bug found by Find Bugs
   http://svn.apache.org/viewvc?rev=699645&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix String comparision bugs found by Find Bugs
   http://svn.apache.org/viewvc?rev=699646&view=rev
   +1: markt
-  -1: 
+  -0: remm (actually, the optimization would be to return the original String
+            if it was not modified, and avoid doing things with a StringBuffer)
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r699697 - /tomcat/tc6.0.x/trunk/STATUS.txt

Posted by Konstantin Kolinko <kn...@gmail.com>.
2008/9/29 Remy Maucherat <re...@apache.org>:
> On Mon, 2008-09-29 at 14:54 +0100, Mark Thomas wrote:
>> remm@apache.org wrote:
>> >  * Fix serialisation issue reported by Find Bugs
>> >    http://svn.apache.org/viewvc?rev=699633&view=rev
>> >    +1: markt
>> > +   0: remm (StdContext was marked as Serializable for an experiment; obviously it won't work)
>> >    -1:
>> Wasn't it part of improving remote JMX support? (Not 100% sure, just a
>> vague recollection.)
>
> I think Costin was experimenting with faster startup.
>

If anyone is interested, from repository history:

introduced in trunk on Jan 27 2003 by Costin
http://svn.apache.org/viewvc?view=rev&revision=301486
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java?r1=301463&r2=301486&pathrev=699633&diff_format=h

The code is now in TC 5.0, 5.5, 6.0.

Also, serializeability was introduced into other classes as well,
http://mail-archives.apache.org/mod_mbox/tomcat-dev/200301.mbox/%3c20030127234520.72692.qmail@icarus.apache.org%3e
http://svn.apache.org/viewvc?view=rev&revision=301491

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r699697 - /tomcat/tc6.0.x/trunk/STATUS.txt

Posted by Remy Maucherat <re...@apache.org>.
On Mon, 2008-09-29 at 14:54 +0100, Mark Thomas wrote:
> remm@apache.org wrote:
> >  * Fix serialisation issue reported by Find Bugs
> >    http://svn.apache.org/viewvc?rev=699633&view=rev
> >    +1: markt
> > +   0: remm (StdContext was marked as Serializable for an experiment; obviously it won't work)
> >    -1:
> Wasn't it part of improving remote JMX support? (Not 100% sure, just a
> vague recollection.)

I think Costin was experimenting with faster startup.

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r699697 - /tomcat/tc6.0.x/trunk/STATUS.txt

Posted by Mark Thomas <ma...@apache.org>.
remm@apache.org wrote:
>  * Fix serialisation issue reported by Find Bugs
>    http://svn.apache.org/viewvc?rev=699633&view=rev
>    +1: markt
> +   0: remm (StdContext was marked as Serializable for an experiment; obviously it won't work)
>    -1:
Wasn't it part of improving remote JMX support? (Not 100% sure, just a
vague recollection.)

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org