[GitHub] [tvm] cconvey commented on a change in pull request #10765: [runtime-rpc] Detect time_evaluator infinite loop

[GitBox <gi...@apache.org>]

cconvey commented on a change in pull request #10765:
URL: https://github.com/apache/tvm/pull/10765#discussion_r840935540



##########
File path: src/runtime/rpc/rpc_module.cc
##########
@@ -395,6 +395,16 @@ PackedFunc WrapTimeEvaluator(PackedFunc pf, Device dev, int number, int repeat,
         }
         t->Stop();
         int64_t t_nanos = t->SyncAndGetElapsedNanos();
+
+        if ((min_repeat_ms > 0) && (t_nanos == 0)) {
+          // We're almost certainly caught in an infinite loop, perahsp because something
+          // in the timing mechanism isn't working as expected.
+          LOG(FATAL) << __FILE__ << ":" << __LINE__ << ": "

Review comment:
       Reasonable assumption, but actually it wasn't.  I've fixed this by enabling customized logging when this file is compiled for Hexagon.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org