You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/11/10 23:43:54 UTC

[kudu-CR] TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5044

to review the following change.

Change subject: TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup
......................................................................

TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup

No functional changes.

* Use ScopedCleanup instead of TransitionInProgressDeleter (less code)
* Replace boost::bind with std::bind while in there

Change-Id: I02624b91156250f8f2ac32f7b6afa7e2bd4d3ac7
---
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
2 files changed, 26 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/5044/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02624b91156250f8f2ac32f7b6afa7e2bd4d3ac7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.

Change subject: TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup
......................................................................


Abandoned

Abandoning due to abandoning the preceding patch, which is required for this one.

-- 
To view, visit http://gerrit.cloudera.org:8080/5044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I02624b91156250f8f2ac32f7b6afa7e2bd4d3ac7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>