[GitHub] [hive] mustafaiman commented on a change in pull request #1235: HIVE-23830: Remove shutdownRunner runner after query is committed

[GitBox <gi...@apache.org>]

mustafaiman commented on a change in pull request #1235:
URL: https://github.com/apache/hive/pull/1235#discussion_r452639789



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java
##########
@@ -553,11 +553,13 @@ private void release(boolean releaseLocks) {
         LOG.warn("Exception when releasing locking in destroy: " + e.getMessage());
       }
     }
-    ShutdownHookManager.removeShutdownHook(shutdownRunner);
+    ShutdownHookManager.removeShutdownHook(txnRollbackRunner);
   }
 
   void releaseLocksAndCommitOrRollback(boolean commit) throws LockException {

Review comment:
       This is the one method that is called from everywhere to end a transaction in either way. Definitely more than a cleanup method. So I think we should not rename it to something that signals it is just a cleanup. I did not want to extract the two lines of clean up to another method either. What is your suggestion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org