[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6361: [HUDI-4690][HUDI-4503] Cleaning up Hudi custom Spark `Rule`s

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #6361:
URL: https://github.com/apache/hudi/pull/6361#discussion_r1056726252


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -57,60 +54,82 @@ object HoodieAnalysis {
         }
 
       val nestedSchemaPruningRule = ReflectionUtils.loadClass(nestedSchemaPruningClass).asInstanceOf[Rule[LogicalPlan]]
-      Seq(_ => nestedSchemaPruningRule)
-    } else {
-      Seq.empty
+      rules += (_ => nestedSchemaPruningRule)
     }
+
+    rules
   }
 
   def customResolutionRules: Seq[RuleBuilder] = {
-    val rules: ListBuffer[RuleBuilder] = ListBuffer(
-      // Default rules
-      session => HoodieResolveReferences(session),

Review Comment:
   All custom resolution logic has been removed (we now rely on Spark to resolve all of its own commands)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org